You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2017/08/28 02:43:51 UTC
[GitHub] incubator-weex pull request #656: 0.16 dev fix sticky
GitHub user gubaojian opened a pull request:
https://github.com/apache/incubator-weex/pull/656
0.16 dev fix sticky
1、fix sticky bug, when back to top
2、when child height is zero, appear event in list should be fired
@notdanger
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex 0.16-dev-fix-sticky
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/656.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #656
----
commit d1dafdbfa91efa57b6170ca20cd7c7d4f57b5d20
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-08-28T01:45:24Z
sticky true
commit 5de82f390c9668ad6798d9db6978930c3a371a36
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-08-28T01:46:07Z
fix sticky bug
commit 9e547a49b7734bffb161a8181b33470f726328ec
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-08-28T02:02:45Z
when child height is 0, appear event will not be fired bug fix
commit f0cfa85ee39344b994f384894f999230829e19fb
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-08-28T02:12:46Z
when child height is zero, appear not fired
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #656: 0.16 dev fix sticky
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/656
<!--
0 failure:
4 warning: No Changelog chan..., This PR modify SD..., This PR should up..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR modify SDK code without add/modify testcases.</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/AppearanceHelper.java</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @sospartan , @cxfeng1 to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #656: 0.16 dev fix sticky
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---