You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/03/09 21:42:28 UTC
[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #37: PR CI run only compiles, ignores actual tests
pjfanning opened a new pull request, #37:
URL: https://github.com/apache/incubator-pekko-connectors/pull/37
Nightly job to run all tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #37: PR CI run only compiles, ignores actual tests
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #37:
URL: https://github.com/apache/incubator-pekko-connectors/pull/37#discussion_r1131652963
##########
.github/workflows/nightly-builds.yml:
##########
@@ -0,0 +1,34 @@
+name: Nightly Build
+
+on:
+ schedule:
+ - cron: "21 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Compile, Code Style, Binary Compatibility
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+
+ - name: Set up JDK 8
+ uses: coursier/setup-action@v1.2.1
+ with:
+ jvm: adopt:8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "Run all tests. Run locally with: sbt +~2.13 \"test\""
+ run: sbt +~2.13 "test"
Review Comment:
What does this `~` syntax do exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #37: PR CI run only compiles, ignores actual tests
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #37:
URL: https://github.com/apache/incubator-pekko-connectors/pull/37#discussion_r1131675676
##########
.github/workflows/nightly-builds.yml:
##########
@@ -0,0 +1,34 @@
+name: Nightly Build
+
+on:
+ schedule:
+ - cron: "21 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Compile, Code Style, Binary Compatibility
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+
+ - name: Set up JDK 8
+ uses: coursier/setup-action@v1.2.1
+ with:
+ jvm: adopt:8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "Run all tests. Run locally with: sbt +~2.13 \"test\""
+ run: sbt +~2.13 "test"
Review Comment:
not sure - I just copied it from the existing workflow yml - I can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #37: PR CI run only compiles, ignores actual tests
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #37:
URL: https://github.com/apache/incubator-pekko-connectors/pull/37#discussion_r1131676661
##########
.github/workflows/nightly-builds.yml:
##########
@@ -0,0 +1,34 @@
+name: Nightly Build
+
+on:
+ schedule:
+ - cron: "21 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Compile, Code Style, Binary Compatibility
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+
+ - name: Set up JDK 8
+ uses: coursier/setup-action@v1.2.1
+ with:
+ jvm: adopt:8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "Run all tests. Run locally with: sbt +~2.13 \"test\""
+ run: sbt +~2.13 "test"
Review Comment:
I would say leave it in there, was just curious. Ill approve the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] raboof commented on a diff in pull request #37: PR CI run only compiles, ignores actual tests
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #37:
URL: https://github.com/apache/incubator-pekko-connectors/pull/37#discussion_r1132083086
##########
.github/workflows/nightly-builds.yml:
##########
@@ -0,0 +1,34 @@
+name: Nightly Build
+
+on:
+ schedule:
+ - cron: "21 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ name: Compile, Code Style, Binary Compatibility
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+
+ - name: Set up JDK 8
+ uses: coursier/setup-action@v1.2.1
+ with:
+ jvm: adopt:8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "Run all tests. Run locally with: sbt +~2.13 \"test\""
+ run: sbt +~2.13 "test"
Review Comment:
> What does this `~` syntax do exactly?
It means "run with whatever 2.13 patch version is used in the build". This way the versions can't get out of sync between the sbt configuration and the invocations in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning merged pull request #37: PR CI run only compiles, ignores actual tests
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #37:
URL: https://github.com/apache/incubator-pekko-connectors/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org