You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2017/02/07 20:52:16 UTC
[06/13] qpid-proton git commit: PROTON-1395: go: testing with -race
fails on some platforms
PROTON-1395: go: testing with -race fails on some platforms
Remove -race from the default GO_TEST_FLAGS as it causes problems on some
platforms. You can enable it in cmake by adding -race to the GO_TEST_FLAGS
value (and are encouraged to if your platform supports it)
Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/6a235006
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/6a235006
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/6a235006
Branch: refs/heads/go1
Commit: 6a235006808750454bdeb35a1bd3195a914b5a0d
Parents: e0ec0b6
Author: Alan Conway <ac...@redhat.com>
Authored: Wed Feb 1 14:03:50 2017 -0500
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Feb 1 14:03:50 2017 -0500
----------------------------------------------------------------------
proton-c/bindings/go/CMakeLists.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/6a235006/proton-c/bindings/go/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/proton-c/bindings/go/CMakeLists.txt b/proton-c/bindings/go/CMakeLists.txt
index 16c633b..d0ffe9b 100644
--- a/proton-c/bindings/go/CMakeLists.txt
+++ b/proton-c/bindings/go/CMakeLists.txt
@@ -22,14 +22,13 @@ execute_process(COMMAND ${GO_EXE} version OUTPUT_VARIABLE go_ver OUTPUT_STRIP_TR
message(STATUS "Found Go: ${GO_EXE} (${go_ver})")
set(GO_BUILD_FLAGS "" CACHE STRING "Flags for 'go build'")
+set(GO_TEST_FLAGS "-v" CACHE STRING "Flags for 'go test'")
# Flags that differ for golang go and gcc go.
if (go_ver MATCHES "gccgo")
# TODO aconway 2015-10-08: import cycles with -race under gccgo, investigate.
- set(GO_TEST_FLAGS "-v" CACHE STRING "Flags for 'go test'")
set(GO_RPATH_FLAGS -gccgoflags "-Wl,-rpath=${CMAKE_BINARY_DIR}/proton-c")
else()
- set(GO_TEST_FLAGS "-v -race" CACHE STRING "Flags for 'go test'")
set(GO_RPATH_FLAGS -ldflags "-r ${CMAKE_BINARY_DIR}/proton-c")
endif()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org