You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <e....@gmx.net> on 2004/02/27 19:43:21 UTC
Remarks on backports from STATUS
Reviewing the changes in STATUS for backporting to 1.0.x I found the
following issues:
* r8839 (import doesn't handle eol-style and keywords)
the changed function send_file_contents leaks a temporary file when and
error
occurs between the creation of the temp file and temp file cleanup. I
think
an additional commit should solve that before merging this to 1.0.x.
* r8551 (cause blame to bail on binary files)
This revision adds a new error code which I think is inappropriate for
micro
releases due to our forward and backward compatibility restraints on the
API.
For this reason I've put a -1 in status. Returning another error until
1.1 would
solve this issue as far as I'm concerned.
I think SVN_ERR_ILLEGAL_TARGET is somewhat cryptic but gets closest to
being reasonable.
bye,
Erik.
--
GMX ProMail (250 MB Mailbox, 50 FreeSMS, Virenschutz, 2,99 EUR/Monat...)
jetzt 3 Monate GRATIS + 3x DER SPIEGEL +++ http://www.gmx.net/derspiegel +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Remarks on backports from STATUS
Posted by Erik Huelsmann <e....@gmx.net>.
> Huh? What STATUS file are you looking at? I see this:
>
> * Issue #1733, attachment 305
> Backport r8551 to 1.0.X to cause blame to bail on binary files.
> Justification: Nicer behavior to the end user.
> Votes:
> +1: sussman, cmpilato
>
> I don't see your -1...?
In which case it's a good thing that I did not commit it yet...
I'm not vetoing the backposrt, so I won't commit it :-)
> And we *have* done a backport that is slightly different from r8551,
> specifically a backport which doesn't create a new error code. We're
> nominating the patch, not r8551 itself. Look at issue #1733. We've
> already been down this road. :-)
bye,
Erik.
--
GMX ProMail (250 MB Mailbox, 50 FreeSMS, Virenschutz, 2,99 EUR/Monat...)
jetzt 3 Monate GRATIS + 3x DER SPIEGEL +++ http://www.gmx.net/derspiegel +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Remarks on backports from STATUS
Posted by Ben Collins-Sussman <su...@collab.net>.
On Fri, 2004-02-27 at 13:43, Erik Huelsmann wrote:
> * r8551 (cause blame to bail on binary files)
> This revision adds a new error code which I think is inappropriate for
> micro
> releases due to our forward and backward compatibility restraints on the
> API.
> For this reason I've put a -1 in status. Returning another error until
> 1.1 would
> solve this issue as far as I'm concerned.
Huh? What STATUS file are you looking at? I see this:
* Issue #1733, attachment 305
Backport r8551 to 1.0.X to cause blame to bail on binary files.
Justification: Nicer behavior to the end user.
Votes:
+1: sussman, cmpilato
I don't see your -1...?
And we *have* done a backport that is slightly different from r8551,
specifically a backport which doesn't create a new error code. We're
nominating the patch, not r8551 itself. Look at issue #1733. We've
already been down this road. :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org