You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/08/03 20:36:26 UTC

[PR] [SPARK-53086][TESTS] Revise Scalastyle RegexChecker patterns [spark]

dongjoon-hyun opened a new pull request, #51799:
URL: https://github.com/apache/spark/pull/51799

   ### What changes were proposed in this pull request?
   
   This PR aims to revise `Scalastyle` RegexChecker patterns.
   
   ### Why are the changes needed?
   
   To detect more accurately.
   
   | BEFORE | AFTER | REASON |
   |---|---|---|
   | `FileSystem.` | `FileSystem\.` | To match `.` exactly |
   | `FileUtils\.` | `[^k]FileUtils\.` | To avoid `SparkFileUtils` |
   | `StringUtils\.` | `[^k]StringUtils\.` | To avoid `SparkStringUtils` |
   | `IOUtils\.` | `[^a]IOUtils\.` | To avoid `ShuffleDataIOUtils` |
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53086][TESTS] Revise Scalastyle RegexChecker patterns [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #51799: [SPARK-53086][TESTS] Revise Scalastyle RegexChecker patterns
URL: https://github.com/apache/spark/pull/51799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53086][TESTS] Revise Scalastyle RegexChecker patterns [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #51799:
URL: https://github.com/apache/spark/pull/51799#issuecomment-3148704449

   Thanks, @zhztheplayer .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53086][TESTS] Revise Scalastyle RegexChecker patterns [spark]

Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #51799:
URL: https://github.com/apache/spark/pull/51799#issuecomment-3148703481

   > To avoid SparkFileUtils
   
   Java RegEx engine supports `\b` anchor (https://www.regular-expressions.info/wordboundaries.html), which may be helpful for these cases :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-53086][TESTS] Revise Scalastyle RegexChecker patterns [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #51799:
URL: https://github.com/apache/spark/pull/51799#issuecomment-3148780757

   Thank you, @HyukjinKwon .
   
   I verified this Scala linter PR manually.
   
   ```
   $ dev/lint-scala
   Using SPARK_LOCAL_IP=localhost
   Scalastyle checks passed.
   Scalafmt checks passed.
   ```
   
   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org