[GitHub] [iceberg] jackye1995 commented on a change in pull request #3104: Core: add snapshot reference to table metadata

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #3104:
URL: https://github.com/apache/iceberg/pull/3104#discussion_r737135474



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -635,8 +656,11 @@ public TableMetadata removeSnapshotsIf(Predicate<Snapshot> removeIf) {
       }
     }
 
-    // update the snapshot log
+    // update the snapshot log and refs
     Set<Long> validIds = Sets.newHashSet(Iterables.transform(filtered, Snapshot::snapshotId));
+    List<SnapshotReference> newRefs = refs.stream()

Review comment:
       my thought is that remove snapshot should work as usual without failing for snapshot with ref, and predicate should be formulated based on ref information.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org