You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2012/03/20 12:02:11 UTC

Re: svn commit: r1302748 - in /commons/proper/io/trunk: ./ src/main/java/org/apache/commons/io/ src/main/java/org/apache/commons/io/comparator/ src/main/java/org/apache/commons/io/filefilter/ src/main/java/org/apache/commons/io/input/ src/main/java/o

On 20 March 2012 01:35,  <gg...@apache.org> wrote:
> Author: ggregory
> Date: Tue Mar 20 01:35:32 2012
> New Revision: 1302748
>
> URL: http://svn.apache.org/viewvc?rev=1302748&view=rev
> Log:
> Remove noisy and unnecessary parens. Especially painful in return statements: "return (foo + bar);" vs. "return foo + bar;"
>
> Modified:
>    commons/proper/io/trunk/pom.xml
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/DirectoryWalker.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileCleaningTracker.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileSystemUtils.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileUtils.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/FilenameUtils.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/HexDump.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/IOUtils.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/comparator/DirectoryFileComparator.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/DelegateFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/EmptyFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/WildcardFileFilter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/BOMInputStream.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/CharSequenceReader.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/NullInputStream.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/NullReader.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/SwappedDataInputStream.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/XmlStreamReader.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/monitor/FileAlterationObserver.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/monitor/FileEntry.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/StringBuilderWriter.java
>    commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/ThresholdingOutputStream.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/DirectoryWalkerTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/DirectoryWalkerTestCaseJava4.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileSystemUtilsTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/FilenameUtilsWildcardTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/IOCaseTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/IOUtilsTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/LineIteratorTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/NullInputStreamTest.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/NullReaderTest.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java
>    commons/proper/io/trunk/src/test/java/org/apache/commons/io/output/XmlStreamWriterTest.java
>
> Modified: commons/proper/io/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/pom.xml?rev=1302748&r1=1302747&r2=1302748&view=diff
> ==============================================================================
> --- commons/proper/io/trunk/pom.xml (original)
> +++ commons/proper/io/trunk/pom.xml Tue Mar 20 01:35:32 2012
> @@ -24,7 +24,7 @@
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>commons-io</groupId>
>   <artifactId>commons-io</artifactId>
> -  <version>2.2-SNAPSHOT</version>
> +  <version>2.2</version>

Huh?

Changed to 23-SNAPSHOT, as release versions cause problems for CI
bots, not to mention developers testing deploy ...

>   <name>Commons IO</name>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1302748 - in /commons/proper/io/trunk: ./ src/main/java/org/apache/commons/io/ src/main/java/org/apache/commons/io/comparator/ src/main/java/org/apache/commons/io/filefilter/ src/main/java/org/apache/commons/io/input/ src/main/java/o

Posted by Gary Gregory <ga...@gmail.com>.
On Tue, Mar 20, 2012 at 7:02 AM, sebb <se...@gmail.com> wrote:

> On 20 March 2012 01:35,  <gg...@apache.org> wrote:
> > Author: ggregory
> > Date: Tue Mar 20 01:35:32 2012
> > New Revision: 1302748
> >
> > URL: http://svn.apache.org/viewvc?rev=1302748&view=rev
> > Log:
> > Remove noisy and unnecessary parens. Especially painful in return
> statements: "return (foo + bar);" vs. "return foo + bar;"
> >
> > Modified:
> >    commons/proper/io/trunk/pom.xml
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/DirectoryWalker.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileCleaningTracker.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileSystemUtils.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileUtils.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/FilenameUtils.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/HexDump.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/IOUtils.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/comparator/DirectoryFileComparator.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/DelegateFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/EmptyFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/RegexFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/filefilter/WildcardFileFilter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/BOMInputStream.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/CharSequenceReader.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/NullInputStream.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/NullReader.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/SwappedDataInputStream.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/XmlStreamReader.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/monitor/FileAlterationObserver.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/monitor/FileEntry.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/StringBuilderWriter.java
> >
>  commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/ThresholdingOutputStream.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/DirectoryWalkerTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/DirectoryWalkerTestCaseJava4.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileSystemUtilsTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/FilenameUtilsWildcardTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/IOCaseTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/IOUtilsTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/LineIteratorTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/NullInputStreamTest.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/NullReaderTest.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/compatibility/XmlStreamReader.java
> >
>  commons/proper/io/trunk/src/test/java/org/apache/commons/io/output/XmlStreamWriterTest.java
> >
> > Modified: commons/proper/io/trunk/pom.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/io/trunk/pom.xml?rev=1302748&r1=1302747&r2=1302748&view=diff
> >
> ==============================================================================
> > --- commons/proper/io/trunk/pom.xml (original)
> > +++ commons/proper/io/trunk/pom.xml Tue Mar 20 01:35:32 2012
> > @@ -24,7 +24,7 @@
> >   <modelVersion>4.0.0</modelVersion>
> >   <groupId>commons-io</groupId>
> >   <artifactId>commons-io</artifactId>
> > -  <version>2.2-SNAPSHOT</version>
> > +  <version>2.2</version>
>
> Huh?
>

That was a mistake. Good catch. Thank you.
Gary

>
> Changed to 23-SNAPSHOT, as release versions cause problems for CI
> bots, not to mention developers testing deploy ...
>
> >   <name>Commons IO</name>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory