You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/09/19 22:25:00 UTC
[jira] [Commented] (IMPALA-7420) Alternative cancellation messages
with "internal" cancellation
[ https://issues.apache.org/jira/browse/IMPALA-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621274#comment-16621274 ]
ASF subversion and git services commented on IMPALA-7420:
---------------------------------------------------------
Commit 4845f98beecc90775f58e8e3eb72721e02252f18 in impala's branch refs/heads/master from [~tarmstrong@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=4845f98 ]
IMPALA-7420: different error code for internal cancellation
I started by converting scan and spill-to-disk because the
cancellation there is always meant to be internal to the scan and
spill-to-disk subsystems.
I updated all places that checked for TErrorCode::CANCELLED to treat
CANCELLED_INTERNALLY the same.
This is to aid triage and debugging of bugs like IMPALA-7418
where an "internal" cancellation leaks out into the query state.
This will make it easier to determine if an internal cancellation
somehow "leaked" out.
Testing:
Ran exhaustive tests.
Change-Id: If25d5b539d68981359e4d881cae7b08728ba2999
Reviewed-on: http://gerrit.cloudera.org:8080/11464
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Alternative cancellation messages with "internal" cancellation
> --------------------------------------------------------------
>
> Key: IMPALA-7420
> URL: https://issues.apache.org/jira/browse/IMPALA-7420
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
>
> All CANCELLED statuses now have the same error message regardless of the source of the cancellation. There are many places in the code where we propagate "CANCELLED" statuses around the place internally, e.g. within scans, for reasons unrelated to user-initiated cancellation. Those should not leak
> IMPALA-7418 was much harder to debug than necessary because it wasn't clear where the CANCELLED status came from.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org