[jira] [Commented] (CB-9422) is required for Android

["Richard B Knoll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145489#comment-15145489 ] 

Richard B Knoll commented on CB-9422:
-------------------------------------

I feel like this is an Android bug. The documentation for this preference indicates that the value should be the name of the resource. We are ignoring that value and arbitrarily renaming all of the images to be "screen.png". I think we should respect the value given and name the resource accordingly.

> <preference name="SplashScreen" value="screen" /> is required for Android
> -------------------------------------------------------------------------
>
>                 Key: CB-9422
>                 URL: https://issues.apache.org/jira/browse/CB-9422
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Docs
>    Affects Versions: 5.1.1
>            Reporter: Sebastien Lorber
>              Labels: Android, Docs-6.x, triaged
>
> When using something like
> {code}
>     <platform name="android">
>         <icon src="www/stample_icon.png" density="ldpi" />
>         <icon src="www/stample_icon.png" density="mdpi" />
>         <icon src="www/stample_icon.png" density="hdpi" />
>         <icon src="www/stample_icon.png" density="xhdpi" />
>         <splash src="www/stample_splash.png" density="land-hdpi"/>
>         <splash src="www/stample_splash.png" density="land-ldpi"/>
>         <splash src="www/stample_splash.png" density="land-mdpi"/>
>         <splash src="www/stample_splash.png" density="land-xhdpi"/>
>         <splash src="www/stample_splash.png" density="port-hdpi"/>
>         <splash src="www/stample_splash.png" density="port-ldpi"/>
>         <splash src="www/stample_splash.png" density="port-mdpi"/>
>         <splash src="www/stample_splash.png" density="port-xhdpi"/>
>     </platform>
> {code}
> The splash screen items are copied to their respestive android folders:
> {code}
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-land-hdpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-land-ldpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-land-mdpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-land-xhdpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-port-hdpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-port-ldpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-port-mdpi/screen.png
> copying image from /home/sebastien/Desktop/Stample-react/cordova/www/stample_splash.png to /home/sebastien/Desktop/Stample-react/cordova/platforms/android/res/drawable-port-xhdpi/screen.png
> {code}
> They are always copied with the name "screen.png"
> If we don't use the option
> {code}
> <preference name="SplashScreen" value="screen" />
> {code}
> Then the splash screen we declare in the xml is simply ignored. The value must be = "screen".
> I think this should be documented, or better: be made the default behavior when a splash screen is declared.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org