You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/01 11:20:10 UTC

[GitHub] [arrow] Dandandan commented on a change in pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Dandandan commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550758655



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -123,7 +119,7 @@ where
     let arrow_schema_metadata = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
         .map(|encoded| get_arrow_schema_from_metadata(&encoded))
-        .unwrap_or_default();
+        .map_or(Ok(None), |v| v.map(Some))?;

Review comment:
       I think you can use it here to




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org