You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jimmy Xiang <jx...@apache.org> on 2015/12/08 01:05:52 UTC

Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/
-----------------------------------------------------------

Review request for hive, Szehon Ho and Xuefu Zhang.


Bugs: HIVE-12485
    https://issues.apache.org/jira/browse/HIVE-12485


Repository: hive-git


Description
-------

Added an AuthenticationFilter to secure the HS2 web ui with kerberos


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
  common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
  service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 

Diff: https://reviews.apache.org/r/41062/diff/


Testing
-------

Manually tested it locally.


Thanks,

Jimmy Xiang


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Szehon Ho <sz...@cloudera.com>.

> On Dec. 8, 2015, 10:43 p.m., Szehon Ho wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1861
> > <https://reviews.apache.org/r/41062/diff/1/?file=1155465#file1155465line1861>
> >
> >     We can keep it lower-case to keep it consistent.
> 
> Jimmy Xiang wrote:
>     I thought about this too. We have use.SSL and ssl in other configuration parameters. I am open to change it to lower-case.

Yea I think we should stick with one (lower-case).  SPNEGO and SSL are already there in the configuration several times in lower-case.  It may be too late for hive.server2.use.SSL.


- Szehon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109419
-----------------------------------------------------------


On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 12:05 a.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Jimmy Xiang <jx...@apache.org>.

> On Dec. 8, 2015, 10:43 p.m., Szehon Ho wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1861
> > <https://reviews.apache.org/r/41062/diff/1/?file=1155465#file1155465line1861>
> >
> >     We can keep it lower-case to keep it consistent.

I thought about this too. We have use.SSL and ssl in other configuration parameters. I am open to change it to lower-case.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109419
-----------------------------------------------------------


On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 12:05 a.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109419
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1861)
<https://reviews.apache.org/r/41062/#comment168921>

    We can keep it lower-case to keep it consistent.


- Szehon Ho


On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 12:05 a.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109581
-----------------------------------------------------------

Ship it!


LGTM

- Mohit Sabharwal


On Dec. 9, 2015, 4:35 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 4:35 p.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Jimmy Xiang <jx...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/
-----------------------------------------------------------

(Updated Dec. 9, 2015, 4:35 p.m.)


Review request for hive, Szehon Ho and Xuefu Zhang.


Changes
-------

Changed use.SSL/SPNEGO to lower case.


Bugs: HIVE-12485
    https://issues.apache.org/jira/browse/HIVE-12485


Repository: hive-git


Description
-------

Added an AuthenticationFilter to secure the HS2 web ui with kerberos


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
  common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
  service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 

Diff: https://reviews.apache.org/r/41062/diff/


Testing
-------

Manually tested it locally.


Thanks,

Jimmy Xiang


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Jimmy Xiang <jx...@apache.org>.

> On Dec. 8, 2015, 10:10 p.m., Mohit Sabharwal wrote:
> > common/src/java/org/apache/hive/http/HttpServer.java, line 93
> > <https://reviews.apache.org/r/41062/diff/1/?file=1155466#file1155466line93>
> >
> >     should this be conditional on the cluster itself being kerberized ?
> >     
> >     i.e.
> >         if (UserGroupInformation.isSecurityEnabled()) {
> >     }

No need. When I do the testing, my cluster is not secured.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109411
-----------------------------------------------------------


On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 12:05 a.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109411
-----------------------------------------------------------



common/src/java/org/apache/hive/http/HttpServer.java (line 93)
<https://reviews.apache.org/r/41062/#comment168907>

    should this be conditional on the cluster itself being kerberized ?
    
    i.e.
        if (UserGroupInformation.isSecurityEnabled()) {
    }


- Mohit Sabharwal


On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 12:05 a.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>