[GitHub] [incubator-superset] villebro commented on a change in pull request #8165: [bugfix] fix timegrain addon regression

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8165: [bugfix] fix timegrain addon regression
URL: https://github.com/apache/incubator-superset/pull/8165#discussion_r321899972
 
 

 ##########
 File path: superset/db_engine_specs/base.py
 ##########
 @@ -161,7 +138,7 @@ def get_timestamp_expr(
         :return: TimestampExpression object
         """
         if time_grain:
-            time_expr = cls.time_grain_functions.get(time_grain)
+            time_expr = cls.get_time_grain_functions().get(time_grain)
 
 Review comment:
   I agree; while this should be minimal overhead, stuff like this tends to cause problems down the line left untreated. To avoid the risk of introducing new regressions I will not refactor this now, but added a `TODO` that I will try to remove in the near future (will aim to kill this when removing `name` from `TimeGrain`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org