You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2024/06/13 17:39:33 UTC
[PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
jonvex opened a new pull request, #11449:
URL: https://github.com/apache/hudi/pull/11449
### Change Logs
HoodieFileGroupReader has too many params.
We can get the tableconfig from the metaclient which is also a param.
### Impact
Less params for fg reader
### Risk level (write none, low medium or high below)
low
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11449:
URL: https://github.com/apache/hudi/pull/11449#issuecomment-2166852725
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b21881333bd3870957950fd467189689887ec5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381",
"triggerID" : "6b21881333bd3870957950fd467189689887ec5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b21881333bd3870957950fd467189689887ec5c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11449:
URL: https://github.com/apache/hudi/pull/11449#issuecomment-2166782357
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b21881333bd3870957950fd467189689887ec5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381",
"triggerID" : "6b21881333bd3870957950fd467189689887ec5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b21881333bd3870957950fd467189689887ec5c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #11449:
URL: https://github.com/apache/hudi/pull/11449#discussion_r1638777639
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -92,7 +92,6 @@ public HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
Option<InternalSchema> internalSchemaOpt,
HoodieTableMetaClient hoodieTableMetaClient,
TypedProperties props,
- HoodieTableConfig tableConfig,
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11449:
URL: https://github.com/apache/hudi/pull/11449#discussion_r1638685103
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -92,7 +92,6 @@ public HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
Option<InternalSchema> internalSchemaOpt,
HoodieTableMetaClient hoodieTableMetaClient,
TypedProperties props,
- HoodieTableConfig tableConfig,
Review Comment:
Could you think about simplifying all the parameters? The goal should be that given the file group ID and the query type with the reader context, storage instance, and the minimal set of configs (maybe with meta client), the file group reader should be able to figure out all necessary configs to fill in for reading the records out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex merged PR #11449:
URL: https://github.com/apache/hudi/pull/11449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11449:
URL: https://github.com/apache/hudi/pull/11449#issuecomment-2166465320
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b21881333bd3870957950fd467189689887ec5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381",
"triggerID" : "6b21881333bd3870957950fd467189689887ec5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b21881333bd3870957950fd467189689887ec5c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #11449:
URL: https://github.com/apache/hudi/pull/11449#discussion_r1638737559
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -92,7 +92,6 @@ public HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
Option<InternalSchema> internalSchemaOpt,
HoodieTableMetaClient hoodieTableMetaClient,
TypedProperties props,
- HoodieTableConfig tableConfig,
Review Comment:
Yeah, I can keep getting rid of more. Just want to keep the prs small
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11449:
URL: https://github.com/apache/hudi/pull/11449#issuecomment-2166448035
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b21881333bd3870957950fd467189689887ec5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b21881333bd3870957950fd467189689887ec5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b21881333bd3870957950fd467189689887ec5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11449:
URL: https://github.com/apache/hudi/pull/11449#issuecomment-2166647365
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b21881333bd3870957950fd467189689887ec5c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381",
"triggerID" : "6b21881333bd3870957950fd467189689887ec5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b21881333bd3870957950fd467189689887ec5c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7871] remove tableconfig from filegroup reader params [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11449:
URL: https://github.com/apache/hudi/pull/11449#issuecomment-2166757927
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6b21881333bd3870957950fd467189689887ec5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6b21881333bd3870957950fd467189689887ec5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6b21881333bd3870957950fd467189689887ec5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org