You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/06/24 08:43:49 UTC
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1061: JAMES-3771 Migrate ES-v7 to OpenSearch 2.0
quantranhong1999 commented on code in PR #1061:
URL: https://github.com/apache/james-project/pull/1061#discussion_r905850652
##########
server/apps/cassandra-app/src/test/java/org/apache/james/DockerElasticSearchExtension.java:
##########
@@ -22,9 +22,9 @@
import java.time.Duration;
import java.util.Optional;
-import org.apache.james.backends.es.v7.DockerElasticSearch;
-import org.apache.james.backends.es.v7.DockerElasticSearchSingleton;
-import org.apache.james.backends.es.v7.ElasticSearchConfiguration;
+import org.apache.james.backends.opensearch.DockerElasticSearch;
+import org.apache.james.backends.opensearch.DockerElasticSearchSingleton;
+import org.apache.james.backends.opensearch.ElasticSearchConfiguration;
Review Comment:
I think we should clean up data in @AfterEach (below). I had some falling tests cause not clean up data in TMail before (no need for the fix on James, but we should clean anyway).
##########
server/apps/scaling-pulsar-smtp/src/test/java/org/apache/james/DockerElasticSearchExtension.java:
##########
@@ -22,9 +22,9 @@
import java.time.Duration;
import java.util.Optional;
-import org.apache.james.backends.es.v7.DockerElasticSearch;
-import org.apache.james.backends.es.v7.DockerElasticSearchSingleton;
-import org.apache.james.backends.es.v7.ElasticSearchConfiguration;
+import org.apache.james.backends.opensearch.DockerElasticSearch;
+import org.apache.james.backends.opensearch.DockerElasticSearchSingleton;
+import org.apache.james.backends.opensearch.ElasticSearchConfiguration;
Review Comment:
clean up idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org