You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/08 08:13:33 UTC

[GitHub] [dolphinscheduler] huagetai commented on pull request #9389: [Improvement-9387][master]Remove the lock in the start method of the MasterR…

huagetai commented on PR #9389:
URL: https://github.com/apache/dolphinscheduler/pull/9389#issuecomment-1092581841

   @caishunfeng Let's look at the code of MasterRegistryClient.
   <img width="837" alt="截屏2022-04-08 下午4 02 02" src="https://user-images.githubusercontent.com/1137341/162392905-6445b9c3-c018-4f0c-a801-5ff6fbc490f9.png">
   
   Then we look at the registry method
   <img width="1079" alt="截屏2022-04-08 下午4 06 34" src="https://user-images.githubusercontent.com/1137341/162393852-b82bc08b-7b57-4369-990c-bd73d5551918.png">
   
   Therefore, the lock here is not necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org