You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Kurt Greaves (JIRA)" <ji...@apache.org> on 2017/05/09 06:30:12 UTC
[jira] [Comment Edited] (CASSANDRA-13142) Upgradesstables cancels
compactions unnecessarily
[ https://issues.apache.org/jira/browse/CASSANDRA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002136#comment-16002136 ]
Kurt Greaves edited comment on CASSANDRA-13142 at 5/9/17 6:29 AM:
------------------------------------------------------------------
First go at https://github.com/apache/cassandra/pull/110/files
I've attached the patch here as well.
Patch is against 2.2. doesn't apply cleanly to >=3.0 but happy to fix that once ready for commit.
I just wrote a unit test that seems to work reliably, however it only tests the interrupt method. It could be made more extensive if deemed necessary but wanted to see if anyone had any better ideas on testing first.
was (Author: kurtg):
First go at https://github.com/apache/cassandra/pull/110/files
I've attached the patch here as well.
I just wrote a unit test that seems to work reliably, however it only tests the interrupt method. It could be made more extensive if deemed necessary but wanted to see if anyone had any better ideas on testing first.
> Upgradesstables cancels compactions unnecessarily
> -------------------------------------------------
>
> Key: CASSANDRA-13142
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13142
> Project: Cassandra
> Issue Type: Bug
> Reporter: Kurt Greaves
> Assignee: Kurt Greaves
> Attachments: 13142-v1.patch
>
>
> Since at least 1.2 upgradesstables will cancel any compactions bar validations when run. This was originally determined as a non-issue in CASSANDRA-3430 however can be quite annoying (especially with STCS) as a compaction will output the new version anyway. Furthermore, as per CASSANDRA-12243 it also stops things like view builds and I assume secondary index builds as well which is not ideal.
> We should avoid cancelling compactions unnecessarily.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org