You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2024/02/29 05:15:23 UTC
[PR] Changes based on review (datasketches-java)
jmalkin opened a new pull request, #515:
URL: https://github.com/apache/datasketches-java/pull/515
Including changes suggested from Slack chat. Separate branch so it doesn't reset the larger review state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Changes based on review (datasketches-java)
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #515:
URL: https://github.com/apache/datasketches-java/pull/515#discussion_r1508238583
##########
src/main/java/org/apache/datasketches/filters/bloomfilter/BitArray.java:
##########
@@ -103,7 +108,7 @@ boolean getAndSetBit(final long index) {
return true; // already seen
} else {
Review Comment:
unnecessary else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Changes based on review (datasketches-java)
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin merged PR #515:
URL: https://github.com/apache/datasketches-java/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org