You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/06 14:52:10 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #3757: [HUDI-2005][WIP] Avoiding fs.getFileStatus call in HoodieLogFileReader
nsivabalan opened a new pull request #3757:
URL: https://github.com/apache/hudi/pull/3757
## What is the purpose of the pull request
- Fixing couple of direct fs calls.
- a. HoodieLogFileReader was using fs.getFileStatus on log file path. Fixed to avoid direct fs call
- b. AbstractTableFileSystemView was calling createNewPath for partition which inturn uses fs.exists(). Fixed this to avoid direct fs.exists() call
## Brief change log
- when reverse reading is enabled in HoodieLogFileReader, we do fs.getFileStatus().getLen to know the file length. but if we triage the call, one of the callers actually fetches the log paths from fileSlice and sets it in RealTimeSplit as List<String> for deltaLogPaths. Have added a new methods in RealTimeSplit called deltaLogFileStatus() and this particular caller will leverage the same to re-use the fileStatus and fetch the length as well.
- Within AbstractTableFileSystemView.ensurePartitionLoadedCorrectly(), we create partition path if it does not exists. and so a direct fs.exists() call is made here. Still trying to get a sense of if we need to fix this. In the sense, if ensurePartitionLoadedCorrectly() will only be called for those partitions which exists, is there a need to fix this? Because, actual fix involves adding a new api to TableFileSystemView as below
```
Stream<String> getAllPartitions();
```
and we need to implement the same in all concrete implementations. and expose a new endpoint in timeline server as well. Wondering if there is a real benefit in here. And this is the only place where we need getAllPartitions().
- There are few other places documented [here](https://issues.apache.org/jira/browse/HUDI-2005), but most of them does not quality to be removed. most cases happens for uncommitted data and so we can't route them to TableFileSystemView.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3757: [HUDI-2005] Avoiding direct fs calls in HoodieLogFileReader
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#discussion_r735263839
##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java
##########
@@ -41,6 +42,8 @@
*/
List<String> getDeltaLogPaths();
Review comment:
yes, will take it up as a [follow up.](https://issues.apache.org/jira/browse/HUDI-2613)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7262974f6f78070fbdda2dc2d588894f5c7ca2ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-941025806
@vinothchandar : wrt fix in AbstractTableFileSystemView.ensurePartitionLoadedCorrectly(), lets sync up sometime. I [tried moving](https://github.com/apache/hudi/pull/3769) the (create if not exists) within listPartitions() call so that we create only incase of metadata disabled, but running into some issues there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7262974f6f78070fbdda2dc2d588894f5c7ca2ef UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005] Avoiding direct fs calls in HoodieLogFileReader
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
}, {
"hash" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775",
"triggerID" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"triggerType" : "PUSH"
}, {
"hash" : "2e402177e5cbf4167bfdc8204ce42b244b2a9dca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e402177e5cbf4167bfdc8204ce42b244b2a9dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775)
* 2e402177e5cbf4167bfdc8204ce42b244b2a9dca UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005] Avoiding direct fs calls in HoodieLogFileReader
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
}, {
"hash" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775",
"triggerID" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"triggerType" : "PUSH"
}, {
"hash" : "2e402177e5cbf4167bfdc8204ce42b244b2a9dca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2787",
"triggerID" : "2e402177e5cbf4167bfdc8204ce42b244b2a9dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e402177e5cbf4167bfdc8204ce42b244b2a9dca Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2787)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
}, {
"hash" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775",
"triggerID" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005] Avoiding direct fs calls in HoodieLogFileReader
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
}, {
"hash" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775",
"triggerID" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"triggerType" : "PUSH"
}, {
"hash" : "2e402177e5cbf4167bfdc8204ce42b244b2a9dca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2787",
"triggerID" : "2e402177e5cbf4167bfdc8204ce42b244b2a9dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775)
* 2e402177e5cbf4167bfdc8204ce42b244b2a9dca Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2787)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #3757: [HUDI-2005] Avoiding direct fs calls in HoodieLogFileReader
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#discussion_r734361882
##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java
##########
@@ -41,6 +42,8 @@
*/
List<String> getDeltaLogPaths();
Review comment:
Since FileStatus already includes the path, do we still need this API?
If not, maybe we can take it up as a follow up task as removing it might require some more testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3757: [HUDI-2005] Avoiding direct fs calls in HoodieLogFileReader
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3757:
URL: https://github.com/apache/hudi/pull/3757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7262974f6f78070fbdda2dc2d588894f5c7ca2ef Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
}, {
"hash" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7262974f6f78070fbdda2dc2d588894f5c7ca2ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519)
* 72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3757: [HUDI-2005][WIP] Avoiding direct fs calls in HoodieLogFileReader and AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3757:
URL: https://github.com/apache/hudi/pull/3757#issuecomment-936434081
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519",
"triggerID" : "7262974f6f78070fbdda2dc2d588894f5c7ca2ef",
"triggerType" : "PUSH"
}, {
"hash" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775",
"triggerID" : "72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7262974f6f78070fbdda2dc2d588894f5c7ca2ef Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2519)
* 72f70dac820537963d3c7deb1ec8b1bfe0b4dcf4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2775)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org