You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/05/16 07:49:36 UTC

[kyuubi] branch branch-1.7 updated: [KYUUBI #4807] [TEST] Retry more times to fix flaky test "spnego batch rest client"

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/branch-1.7 by this push:
     new d33a841bb [KYUUBI #4807] [TEST] Retry more times to fix flaky test "spnego batch rest client"
d33a841bb is described below

commit d33a841bbe4cf7ba174551ef8b3b99cdafa5b6b1
Author: liangbowen <li...@gf.com.cn>
AuthorDate: Tue May 16 15:49:11 2023 +0800

    [KYUUBI #4807] [TEST] Retry more times to fix flaky test "spnego batch rest client"
    
    ### _Why are the changes needed?_
    
    - retry more times for `spnego batch rest client` ut of `BatchRestApiSuite`
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4807 from bowenliang123/fix-spnego-batch.
    
    Closes #4807
    
    2b10ba5b3 [liangbowen] update
    f1563c784 [liangbowen] try to retry in longer time with eventually
    
    Authored-by: liangbowen <li...@gf.com.cn>
    Signed-off-by: Cheng Pan <ch...@apache.org>
    (cherry picked from commit 28216324cd7737fc2dcfd4c7b34590261f783d18)
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala    | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala
index cb7905286..ef53fbe3e 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala
@@ -162,8 +162,10 @@ class BatchRestApiSuite extends RestClientTestHelper with BatchTestHelper {
     assert(batch.getBatchType === "SPARK")
 
     // get batch log
-    val log = batchRestApi.getBatchLocalLog(batch.getId(), 0, 1)
-    assert(log.getRowCount == 1)
+    eventually(timeout(1.minutes)) {
+      val log = batchRestApi.getBatchLocalLog(batch.getId(), 0, 1)
+      assert(log.getRowCount == 1)
+    }
 
     // delete batch
     val closeResp = batchRestApi.deleteBatch(batch.getId(), proxyUser)