You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@httpd.apache.org by GitBox <gi...@apache.org> on 2021/04/23 23:51:52 UTC

[GitHub] [httpd] I-Cat opened a new pull request #181: change 2493 urls

I-Cat opened a new pull request #181:
URL: https://github.com/apache/httpd/pull/181


   Commit:
   change 2493 urls from http:// to https://
   
   Signed off by  -- @I-Cat


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org


[GitHub] [httpd] I-Cat commented on pull request #181: change 2493 urls [Wait for Travis] 🚧

Posted by GitBox <gi...@apache.org>.
I-Cat commented on pull request #181:
URL: https://github.com/apache/httpd/pull/181#issuecomment-826108168


   > This may have damaged the korean translations (diff in github looks suspicious) updates all the license/copyright headers for nearly every file, and hit at least 1 URL that had an explicit port 80 in it. It also means things like /server-status and /server-info examples don't work w/o TLS. I don't really see the added value to offset this.
   Reply to : @covener covener
   
   > Message:
   Yes Thank you for your input.  Maybe changing all the URLs to https:// all at once was a little much. That's odd, I will check the diff and see what happened to the port. Also will close and revert. The only way I could test this was by a pull request. Is there a nother way I can test this before I make a pull request?  Then I can verify a passing build. All advice is appreciated.
   
   Signed-off-by: I-CAT
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org


[GitHub] [httpd] covener commented on pull request #181: change 2493 urls [Wait for Travis] 🚧

Posted by GitBox <gi...@apache.org>.
covener commented on pull request #181:
URL: https://github.com/apache/httpd/pull/181#issuecomment-826007208


   This may have damaged the korean translations (diff in github looks suspicious) updates all the license/copyright headers for nearly every file,  and hit at least 1 URL that had an explicit port 80 in it. It also means things like /server-status and /server-info examples don't work w/o TLS.  I don't really see the added value to offset this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org


[GitHub] [httpd] I-Cat edited a comment on pull request #181: change 2493 urls [Wait for Travis] 🚧

Posted by GitBox <gi...@apache.org>.
I-Cat edited a comment on pull request #181:
URL: https://github.com/apache/httpd/pull/181#issuecomment-826108168


   > This may have damaged the korean translations (diff in github looks suspicious) updates all the license/copyright headers for nearly every file, and hit at least 1 URL that had an explicit port 80 in it. It also means things like /server-status and /server-info examples don't work w/o TLS. I don't really see the added value to offset this.
   Reply to : @covener covener
   
   > Message:
   Yes Thank you for your input.  Maybe changing all the URLs to https:// all at once was a little much. That's odd, I will check the diff and see what happened to the port. Also will close and revert. The only way I could test this was by a pull request. Is there a nother way I can test this before I make a pull request?  Then I can verify a passing build. All advice is appreciated.
   
   Signed-off-by: I-Cat
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org


[GitHub] [httpd] I-Cat commented on pull request #181: change 2493 urls [Wait for Travis] 🚧

Posted by GitBox <gi...@apache.org>.
I-Cat commented on pull request #181:
URL: https://github.com/apache/httpd/pull/181#issuecomment-826108168


   > This may have damaged the korean translations (diff in github looks suspicious) updates all the license/copyright headers for nearly every file, and hit at least 1 URL that had an explicit port 80 in it. It also means things like /server-status and /server-info examples don't work w/o TLS. I don't really see the added value to offset this.
   Reply to : @covener covener
   
   > Message:
   Yes Thank you for your input.  Maybe changing all the URLs to https:// all at once was a little much. That's odd, I will check the diff and see what happened to the port. Also will close and revert. The only way I could test this was by a pull request. Is there a nother way I can test this before I make a pull request?  Then I can verify a passing build. All advice is appreciated.
   
   Signed-off-by: I-CAT
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org


[GitHub] [httpd] I-Cat edited a comment on pull request #181: change 2493 urls [Wait for Travis] 🚧

Posted by GitBox <gi...@apache.org>.
I-Cat edited a comment on pull request #181:
URL: https://github.com/apache/httpd/pull/181#issuecomment-826108168


   > This may have damaged the korean translations (diff in github looks suspicious) updates all the license/copyright headers for nearly every file, and hit at least 1 URL that had an explicit port 80 in it. It also means things like /server-status and /server-info examples don't work w/o TLS. I don't really see the added value to offset this.
   Reply to : @covener covener
   
   > Message:
   Yes Thank you for your input.  Maybe changing all the URLs to https:// all at once was a little much. That's odd, I will check the diff and see what happened to the port. Also will close and revert. The only way I could test this was by a pull request. Is there a nother way I can test this before I make a pull request?  Then I can verify a passing build. All advice is appreciated.
   
   Signed-off-by: I-Cat
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org