[jira] [Commented] (KAFKA-9018) Kafka Connect - throw clearer exceptions on serialisation errors

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949099#comment-16949099 ] 

ASF GitHub Bot commented on KAFKA-9018:
---------------------------------------

mmolimar commented on pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors
URL: https://github.com/apache/kafka/pull/7496
 
 
   When Connect fails on a deserialisation error, it doesn't show if that's the key or value that's thrown the error, nor does it give the user any indication of the topic/partition/offset of the message.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kafka Connect - throw clearer exceptions on serialisation errors
> ----------------------------------------------------------------
>
>                 Key: KAFKA-9018
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9018
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>            Reporter: Robin Moffatt
>            Priority: Minor
>
> When Connect fails on a deserialisation error, it doesn't show if that's the *key or value* that's thrown the error, nor does it give the user any indication of the *topic/partition/offset* of the message. Kafka Connect should be improved to return this information.
> Example message that user will get (in this case caused by reading non-Avro data with the Avro converter)
> {code:java}
> Caused by: org.apache.kafka.connect.errors.DataException: Failed to deserialize data for topic sample_topic to Avro:
>  at io.confluent.connect.avro.AvroConverter.toConnectData(AvroConverter.java:110)
>  at org.apache.kafka.connect.runtime.WorkerSinkTask.lambda$convertAndTransformRecord$1(WorkerSinkTask.java:487)
>  at org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndRetry(RetryWithToleranceOperator.java:128)
>  at org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndHandleError(RetryWithToleranceOperator.java:162)
>  ... 13 more
>  Caused by: org.apache.kafka.common.errors.SerializationException: Error deserializing Avro message for id -1
>  Caused by: org.apache.kafka.common.errors.SerializationException: Unknown magic byte!{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)