You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2008/05/12 11:56:28 UTC
Re: svn commit: r31121 - in trunk: . subversion/libsvn_subr
subversion/tests/libsvn_subr
On Mon, May 12, 2008 at 05:14:41PM +0530, Kamesh Jayachandran wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> This commit causes(actually reveals the hiding path inconsistencies)
> many tests to fail over ra_neon on --enable-maintainer-mode build.
Oh, I'm not testing with ra_neon, maybe I should?
> Following patch is supposed to fix it. Once the tests are over will
> commit the same.
Yay, one more bug fixed because of improved debugging code :)
Thanks Kamesh,
Stefan
>
>
> Index: subversion/libsvn_ra_neon/util.c
> ===================================================================
> - --- subversion/libsvn_ra_neon/util.c (revision 31132)
> +++ subversion/libsvn_ra_neon/util.c (working copy)
> @@ -510,8 +510,10 @@
> */
>
> apr_uri_t uri;
> - - apr_status_t apr_status
> - - = apr_uri_parse(pool, src, &uri);
> + apr_status_t apr_status;
> + /* SRC can have trailing '/' */
> + src = svn_path_canonicalize(src, pool);
> + apr_status = apr_uri_parse(pool, src, &uri);
>
> if (apr_status != APR_SUCCESS)
> return svn_error_wrap_apr(apr_status,
Re: svn commit: r31121 - in trunk: . subversion/libsvn_subr subversion/tests/libsvn_subr
Posted by Kamesh Jayachandran <ka...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stefan Sperling wrote:
> On Mon, May 12, 2008 at 05:14:41PM +0530, Kamesh Jayachandran wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> This commit causes(actually reveals the hiding path inconsistencies)
>> many tests to fail over ra_neon on --enable-maintainer-mode build.
>
> Oh, I'm not testing with ra_neon, maybe I should?
>
>> Following patch is supposed to fix it. Once the tests are over will
>> commit the same.
>
> Yay, one more bug fixed because of improved debugging code :)
>
Committed it in r31135.
With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIKDvR3WHvyO0YTCwRAoivAKCQE7eGoQB/QY1xboJ79nFqj/tyVwCgsbjl
pJqzeLKai/c8y83eJrB64M4=
=/jXt
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org