You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2022/02/10 12:00:00 UTC
[jira] [Comment Edited] (CASSANDRA-17048) Replace sequential sstable generation identifier with UUID v1
[ https://issues.apache.org/jira/browse/CASSANDRA-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490153#comment-17490153 ]
Andres de la Peña edited comment on CASSANDRA-17048 at 2/10/22, 11:59 AM:
--------------------------------------------------------------------------
Thanks, I'll take a look at the changes.
CI is having some issues due to the recent changes on CASSANDRA-15234 and CCM retagging. The workaround is pointing to a dtest repo with [a patched CCM requirement|https://github.com/adelapena/cassandra-dtest/blob/b68cd7572f1114b5146b0841d85634e99791aa30/requirements.txt#L12]. I have run CI with this workaround, let's hope we have better luck this time:
||Branch||CI||
|[trunk|https://github.com/adelapena/cassandra/tree/17048-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1294/workflows/f26243ac-e63d-4e23-8aef-eee2cdc2d773] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1294/workflows/401848c7-a492-4e21-b612-293786f9948a]|
The CircleCI config has been generated with:
{code:java}
.circleci/generate.sh -m \
-e REPEATED_UTEST_TARGET=test-jvm-dtest-some \
-e REPEATED_UTEST_COUNT=100 \
-e REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.SSTableIdGenerationTest \
-e DTEST_REPO=https://github.com/adelapena/cassandra-dtest.git \
-e DTEST_BRANCH=CASSANDRA-15234
{code}
Note that this includes some repeated runs for the new {{{}SSTableIdGenerationTest{}}}, since we have a history of flaky dtests.
was (Author: adelapena):
Thanks, I'll take a look at the changes.
CI is having some issues due to the recent changes on CASSANDRA-15234 and CCM retagging. The workaround is pointing to a dtest repo with a patched CCM requirement. I have run CI with this workaround, let's hope we have better luck this time:
||Branch||CI||
|[trunk|https://github.com/adelapena/cassandra/tree/17048-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1294/workflows/f26243ac-e63d-4e23-8aef-eee2cdc2d773] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1294/workflows/401848c7-a492-4e21-b612-293786f9948a]|
The CircleCI config has been generated with:
{code:java}
.circleci/generate.sh -m \
-e REPEATED_UTEST_TARGET=test-jvm-dtest-some \
-e REPEATED_UTEST_COUNT=100 \
-e REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.SSTableIdGenerationTest \
-e DTEST_REPO=https://github.com/adelapena/cassandra-dtest.git \
-e DTEST_BRANCH=CASSANDRA-15234
{code}
Note that this includes some repeated runs for the new {{{}SSTableIdGenerationTest{}}}, since we have a history of flaky dtests.
> Replace sequential sstable generation identifier with UUID v1
> -------------------------------------------------------------
>
> Key: CASSANDRA-17048
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17048
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
> Reporter: Jacek Lewandowski
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Replace the current sequential sstable generation identifier with ULID based.
> ULID is better because we do not need to scan the existing files to pick the starting number as well as we can generate globally unique identifiers.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org