You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/12 10:16:45 UTC

[GitHub] [camel-k] johnpoth opened a new pull request, #3265: Fix #3257: work with relative paths on windows to avoid extra semicolon

johnpoth opened a new pull request, #3265:
URL: https://github.com/apache/camel-k/pull/3265

   <!-- Description -->
   
   Fixes #3257 until https://github.com/container-tools/spectrum/issues/8 is resolved. Thanks !
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on a diff in pull request #3265: Fix #3257: work with relative paths on windows to avoid extra semicolon

Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3265:
URL: https://github.com/apache/camel-k/pull/3265#discussion_r871340860


##########
pkg/cmd/run.go:
##########
@@ -972,6 +982,22 @@ func (o *runCmdOptions) uploadAsMavenArtifact(dependency maven.Dependency, path
 	return uploadChecksumFiles(path, options, platform, artifactHTTPPath, dependency)
 }
 
+func getRelativeToWorkingDirectory(path string) (string, error) {

Review Comment:
   Let's deprecate this, so we make sure to remove as soon as the root cause is fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi commented on pull request #3265: Fix #3257: work with relative paths on windows to avoid extra semicolon

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3265:
URL: https://github.com/apache/camel-k/pull/3265#issuecomment-1258980387

   @johnpoth FYI, the spectrum fix will be available soon #3675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] johnpoth commented on a diff in pull request #3265: Fix #3257: work with relative paths on windows to avoid extra semicolon

Posted by GitBox <gi...@apache.org>.
johnpoth commented on code in PR #3265:
URL: https://github.com/apache/camel-k/pull/3265#discussion_r871400849


##########
pkg/cmd/run.go:
##########
@@ -972,6 +982,22 @@ func (o *runCmdOptions) uploadAsMavenArtifact(dependency maven.Dependency, path
 	return uploadChecksumFiles(path, options, platform, artifactHTTPPath, dependency)
 }
 
+func getRelativeToWorkingDirectory(path string) (string, error) {

Review Comment:
   Thanks for reviewing @squakez ! Updated, thanks !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez merged pull request #3265: Fix #3257: work with relative paths on windows to avoid extra semicolon

Posted by GitBox <gi...@apache.org>.
squakez merged PR #3265:
URL: https://github.com/apache/camel-k/pull/3265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org