You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/14 13:46:14 UTC

[GitHub] [incubator-mxnet] mseth10 opened a new pull request #18559: add cd mxnet_lib/static stages to ci

mseth10 opened a new pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559


   ## Description ##
   add cd mxnet_lib/static stages to ci
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#discussion_r441081183



##########
File path: ci/jenkins/Jenkinsfile_centos_cpu
##########
@@ -37,14 +37,16 @@ core_logic: {
     custom_steps.compile_centos7_cpu('centos7_cpu'),
     custom_steps.compile_centos7_cpu_make('centos7_cpu_make'),
     custom_steps.compile_centos7_cpu_mkldnn(),
+    custom_steps.compile_static_cd_cpu('centos7_cpu_cd'),

Review comment:
       Done! Also removed custom_steps.compile_static_python_gpu_cmake() that was running cu92 in favor of new stage running cu102.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu merged pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mseth10 edited a comment on pull request #18559: add cd mxnet_lib/static stages to ci

Posted by GitBox <gi...@apache.org>.
mseth10 edited a comment on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-644552613


   @leezu @szha please help review and merge. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mseth10 commented on pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-645062149


   @leezu please help merge the pr. thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mseth10 commented on pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-645012655


   @mxnet-bot run ci [windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-645012723


   Jenkins CI successfully triggered : [windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-645131019


   Thanks for pointing it out. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-645087169


   >  For instance for building binaries for AWS-MXNet we do it on linux 14.04 [and soon migrating to 16 or 18.04]
   
   That would be a bad idea. You want to be compatible with https://www.python.org/dev/peps/pep-0599/ and for that you MUST build on CentOS7 or a system with equivalent glibc version


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mseth10 commented on pull request #18559: add cd mxnet_lib/static stages to ci

Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-644552613


   @leezu please help review and merge. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18559: add cd mxnet_lib/static and python/pypi stages to ci

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-645085628


   Curious why static builds are on Centos [and not on linux]
   For instance for building binaries for AWS-MXNet we do it on linux 14.04 [and soon migrating to 16 or 18.04]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18559: add cd mxnet_lib/static stages to ci

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#discussion_r441049583



##########
File path: ci/jenkins/Jenkinsfile_centos_cpu
##########
@@ -37,14 +37,16 @@ core_logic: {
     custom_steps.compile_centos7_cpu('centos7_cpu'),
     custom_steps.compile_centos7_cpu_make('centos7_cpu_make'),
     custom_steps.compile_centos7_cpu_mkldnn(),
+    custom_steps.compile_static_cd_cpu('centos7_cpu_cd'),

Review comment:
       The new test is a more elaborate version of `custom_steps.compile_static_python_cpu_cmake()` isn't it? If so, let's remove the  `custom_steps.compile_static_python_cpu_cmake()` in favor of the new approach.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18559: add cd mxnet_lib/static stages to ci

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18559:
URL: https://github.com/apache/incubator-mxnet/pull/18559#issuecomment-643768794


   Hey @mseth10 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, windows-gpu, unix-gpu, centos-gpu, centos-cpu, clang, unix-cpu, website, sanity, edge, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org