You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 16:40:56 UTC
[GitHub] [arrow] pitrou opened a new pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
pitrou opened a new pull request #11940:
URL: https://github.com/apache/arrow/pull/11940
Add a new parameter to EqualOptions() to choose whether signed zeros should compare equal.
Ensure that said parameter is set to false in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#discussion_r767952667
##########
File path: cpp/src/arrow/compare.h
##########
@@ -48,6 +48,16 @@ class EqualOptions {
return res;
}
+ /// Whether or not zeros with differing signs are considered equal.
+ bool signed_zeros_equal() const { return signed_zeros_equal_; }
Review comment:
signed_zeros_equal sounds fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992770148
AppVeyor build (green): https://ci.appveyor.com/project/pitrou/arrow/builds/41873970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992882474
Benchmark runs are scheduled for baseline = 5ff33fa47ee291687ec5cfe2c3ad90a9edb92afe and contender = ab467255b6b7d7cf721747c5d10a9b254070eb07. ab467255b6b7d7cf721747c5d10a9b254070eb07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a648f0ff768f49869c70509ff54fd5b0...c01d12198f1a41faa4cb582bd1448b50/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a26f10e7f906493b8aaaec4f62a936f4...0263445754b6486c8a31c1f59ef067cf/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15f77296b5664af9a95ef57c8eacf55d...07d26a41063a4622ab5a47b4feea3427/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992882474
Benchmark runs are scheduled for baseline = 5ff33fa47ee291687ec5cfe2c3ad90a9edb92afe and contender = ab467255b6b7d7cf721747c5d10a9b254070eb07. ab467255b6b7d7cf721747c5d10a9b254070eb07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a648f0ff768f49869c70509ff54fd5b0...c01d12198f1a41faa4cb582bd1448b50/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a26f10e7f906493b8aaaec4f62a936f4...0263445754b6486c8a31c1f59ef067cf/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15f77296b5664af9a95ef57c8eacf55d...07d26a41063a4622ab5a47b4feea3427/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992882474
Benchmark runs are scheduled for baseline = 5ff33fa47ee291687ec5cfe2c3ad90a9edb92afe and contender = ab467255b6b7d7cf721747c5d10a9b254070eb07. ab467255b6b7d7cf721747c5d10a9b254070eb07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a648f0ff768f49869c70509ff54fd5b0...c01d12198f1a41faa4cb582bd1448b50/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a26f10e7f906493b8aaaec4f62a936f4...0263445754b6486c8a31c1f59ef067cf/)
[Finished :arrow_down:0.22% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15f77296b5664af9a95ef57c8eacf55d...07d26a41063a4622ab5a47b4feea3427/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #11940:
URL: https://github.com/apache/arrow/pull/11940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992663315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992701840
Though, it seems there are a few more tests to adjust for Windows and MacOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#discussion_r767951737
##########
File path: cpp/src/arrow/compare.h
##########
@@ -48,6 +48,16 @@ class EqualOptions {
return res;
}
+ /// Whether or not zeros with differing signs are considered equal.
+ bool signed_zeros_equal() const { return signed_zeros_equal_; }
Review comment:
Not sure about the naming here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992663225
cc @edponce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11940: ARROW-12768: [C++] Stricter signed zero comparison in tests
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11940:
URL: https://github.com/apache/arrow/pull/11940#issuecomment-992882474
Benchmark runs are scheduled for baseline = 5ff33fa47ee291687ec5cfe2c3ad90a9edb92afe and contender = ab467255b6b7d7cf721747c5d10a9b254070eb07. ab467255b6b7d7cf721747c5d10a9b254070eb07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a648f0ff768f49869c70509ff54fd5b0...c01d12198f1a41faa4cb582bd1448b50/)
[Failed :arrow_down:0.45% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a26f10e7f906493b8aaaec4f62a936f4...0263445754b6486c8a31c1f59ef067cf/)
[Finished :arrow_down:0.22% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15f77296b5664af9a95ef57c8eacf55d...07d26a41063a4622ab5a47b4feea3427/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org