[GitHub] [arrow-rs] waitingkuo commented on a diff in pull request #2909: Add timezone abstraction

[GitBox <gi...@apache.org>]

waitingkuo commented on code in PR #2909:
URL: https://github.com/apache/arrow-rs/pull/2909#discussion_r1001730751


##########
arrow-array/src/timezone.rs:
##########
@@ -0,0 +1,306 @@
+use arrow_schema::ArrowError;
+use chrono::format::{parse, Parsed, StrftimeItems};
+use chrono::FixedOffset;
+pub use private::{Tz, TzOffset};
+
+/// Parses a fixed offset of the form "+09:00"
+fn parse_fixed_offset(tz: &str) -> Result<FixedOffset, ArrowError> {
+    if tz.len() != 6 {

Review Comment:
   i think we could submit another pr to extend this to support more fixedoffset formats. chrono supports these:
   <img width="978" alt="image" src="https://user-images.githubusercontent.com/1100923/197195930-ad0e0949-0a0a-430f-9efc-3f3c23b410eb.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org