[GitHub] [solr] cpoerschke commented on a diff in pull request #1570: Move duplicated code to method in TaskManagementHandler.java

["cpoerschke (via GitHub)" <gi...@apache.org>]

cpoerschke commented on code in PR #1570:
URL: https://github.com/apache/solr/pull/1570#discussion_r1188282152


##########
solr/solrj/src/java/org/apache/solr/common/params/ModifiableSolrParams.java:
##########
@@ -175,6 +177,18 @@ public boolean remove(String name, String value) {
   // ----------------------------------------------------------------
   // ----------------------------------------------------------------
 
+  public static void setShardAttributesToParams(
+      int purpose, String shard, ModifiableSolrParams params) {

Review Comment:
   subjective: method could be non-static maybe and/or to add test coverage e.g. in `ModifiableSolrParamsTest.java`
   ```suggestion
     public void setShardAttributes(
         int purpose, String shard) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org