[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11551: [Improvement] Dependent tasks support dependent policies

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11551:
URL: https://github.com/apache/dolphinscheduler/pull/11551#discussion_r949725556


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/DependentParameters.java:
##########
@@ -21,11 +21,13 @@
 import org.apache.dolphinscheduler.plugin.task.api.model.DependentTaskModel;
 
 import java.util.List;
+import java.util.Map;
 
 public class DependentParameters extends AbstractParameters {
 
     private List<DependentTaskModel> dependTaskList;
     private DependentRelation relation;
+    private Map<String, Object> otherParams;

Review Comment:
   Could you please describe what is otherParams? And why if the dependent is not exist, we still need to set the otherParams? this is strange.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org