You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2021/02/22 12:49:38 UTC

[GitHub] [incubator-hop] hansva commented on pull request #638: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

hansva commented on pull request #638:
URL: https://github.com/apache/incubator-hop/pull/638#issuecomment-783350471


   Removing the override is not correct and does not solve the error, we are overriding the interface methods. Override is not mandatory in these use cases but it is best practice. the solution is to add a comment in the method stating that it does nothing
   
   ```
   public void beginTask( String message, int nrWorks ) {
   // Does nothing  
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org