You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Saikat Maitra <sa...@gmail.com> on 2020/01/12 18:59:20 UTC
IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Hi,
I have raised PR for Ignite zeromq migration to Ignite Extensions repo.
Jira https://issues.apache.org/jira/browse/IGNITE-12358
PR https://github.com/apache/ignite-extensions/pull/5
https://github.com/apache/ignite/pull/7240
Please review and share feedback.
This is part of our Modularization effort for Streamer modules
https://issues.apache.org/jira/browse/IGNITE-12355
Regards,
Saikat
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hello Denis,
I like the idea of grid layout for displaying the ignite-extensions with
logo and urls.
I can add the logos related to Apache projects but for other integrations
like Twitter I will connect back
which logo can be used in the website.
Regards,
Saikat
On Tue, Apr 7, 2020 at 11:25 AM Denis Magda <dm...@apache.org> wrote:
> >
> > In that case we should be ok to merge these 2 open PRs in master to make
> it
> > available for 2.9.0 release.
> > https://github.com/apache/ignite/pull/7240
> > https://github.com/apache/ignite/pull/7227
> > Can you please review and confirm?
>
>
> Saikat, you are right that nothing prevents us from merging the changes to
> the master that will be used to cut off a 2.9 branch in the future. Please
> go ahead and your changes to the master.
>
> As for the extensions web page, I see its structure as follows. It goes
> with a header introducing the extensions repository and covering types of
> contributions that are welcomed there. Then down below in the body we list
> all the available extensions - it can be a simple table with an extension
> name, description, URL or a bit more advanced interface with a grid layout
> like on this page [1]. With the grid layout, we can add logos of the
> projects Ignite is integrated with in addition to the name/description/URL.
>
> Let me know what you think.
>
> [1] https://ignite.apache.org/screencasts.html
>
> -
> Denis
>
>
> On Sat, Apr 4, 2020 at 3:07 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Hi Denis, Maxim, Ilya
> >
> > I observed that we already have release 2.8.1 branch
> > https://github.com/apache/ignite/tree/ignite-2.8.1
> >
> > In that case we should be ok to merge these 2 open PRs in master to make
> it
> > available for 2.9.0 release.
> >
> > https://github.com/apache/ignite/pull/7240
> > https://github.com/apache/ignite/pull/7227
> >
> > Can you please review and confirm?
> >
> > Denis - I think for Ignite Extensions docs we can merge these 2 following
> > pages and create a single page for Ignite extensions
> >
> > Streaming <https://ignite.apache.org/features/streaming.html>
> > https://ignite.apache.org/features/streaming.html
> > Other Integrations <https://apacheignite-mix.readme.io/docs>
> > https://apacheignite-mix.readme.io/docs
> >
> > Let me know your thoughts.
> >
> > Regards,
> > Saikat
> >
> >
> > On Fri, Apr 3, 2020 at 2:46 PM Denis Magda <dm...@apache.org> wrote:
> >
> > > Hi Saikat,
> > >
> > > I believe that 2.8.x will be cut from 2.8. However, please double-check
> > > with other community members posting the question here:
> > >
> > >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-2-8-1-RELEASE-Time-Scope-Manager-td46452.html#a46453
> > >
> > > -
> > > Denis
> > >
> > >
> > > On Fri, Apr 3, 2020 at 3:05 AM Saikat Maitra <sa...@gmail.com>
> > > wrote:
> > >
> > > > Hello Denis,
> > > >
> > > > Thank you for your email. I know for minor release 2.9 we will be
> > cutting
> > > > release branch from master.
> > > >
> > > > Do you know for maintenance version 2.8.x if we are cutting release
> > > branch
> > > > from master or are we using release branch 2.8.x and cherry picking
> > fixes
> > > > from master?
> > > >
> > > > I wanted to correctly time the merge of open PRs in master so that we
> > can
> > > > make changes available in 2.9 release without impacting 2.8.x
> versions.
> > > >
> > > > Regards,
> > > > Saikat
> > > >
> > > >
> > > >
> > > >
> > > > On Sun, Mar 29, 2020 at 5:59 PM Denis Magda <dm...@apache.org>
> wrote:
> > > >
> > > > > Hi Saikat,
> > > > >
> > > > > My thinking is that the removal should take place with the next
> minor
> > > > > release 2.9. I wouldn't do this in maintenance versions such as
> > 2.8.x.
> > > > >
> > > > > Btw, how about creating a page for Ignite extensions on the website
> > > that
> > > > > will be placed under "Features" menu? Would you be interested in
> > that?
> > > > >
> > > > > -
> > > > > Denis
> > > > >
> > > > >
> > > > > On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <
> > saikat.maitra@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hello,
> > > > > >
> > > > > > I wanted to discuss on merge process for PR in ignite modules
> when
> > we
> > > > are
> > > > > > migrating extensions.
> > > > > >
> > > > > > I have created these 2 PR for ZeroMQ to migrate from ignite to
> > ignite
> > > > > > extension repo and also to remove ZeroMQ from ignite repo.
> > > > > >
> > > > > >
> > > > > > https://github.com/apache/ignite-extensions/pull/5
> > > > > > https://github.com/apache/ignite/pull/7240
> > > > > >
> > > > > > Both the PR are reviewed and in approved state and I have merged
> > the
> > > > > > changes for ignite-extensions.
> > > > > >
> > > > > > I wanted to discuss if this is right time to merge removal of
> > ZeroMQ
> > > > > module
> > > > > > PR from ignite repo or shall I wait for initial release of
> > > > > > ignite-extensions - ZeroMQ module?
> > > > > >
> > > > > > Regards,
> > > > > > Saikat
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <
> > > saikat.maitra@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Mikhail,
> > > > > > >
> > > > > > > Thank you for help in review. I have merged the changes.
> > > > > > >
> > > > > > > Regards,
> > > > > > > Saikat
> > > > > > >
> > > > > > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <
> > > > saikat.maitra@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Hi Ilya, Mikhail
> > > > > > >>
> > > > > > >> I have updated the PR as per review comments.
> > > > > > >>
> > > > > > >> Please take a look and share your feedback.
> > > > > > >>
> > > > > > >> PR https://github.com/apache/ignite-extensions/pull/5
> > > > > > >> https://github.com/apache/ignite/pull/7240
> > > > > > >>
> > > > > > >> Regards,
> > > > > > >> Saikat
> > > > > > >>
> > > > > > >>
> > > > > > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <
> > > > > saikat.maitra@gmail.com>
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >>> Hello,
> > > > > > >>>
> > > > > > >>> Can someone please help in review for these following PRs. I
> > have
> > > > > > >>> received approval for release process from Alexey and would
> > need
> > > a
> > > > > code
> > > > > > >>> review approval for following PR.
> > > > > > >>>
> > > > > > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > > > > >>>
> > > > > > >>> PR https://github.com/apache/ignite-extensions/pull/5
> > > > > > >>> https://github.com/apache/ignite/pull/7240
> > > > > > >>>
> > > > > > >>>
> > > > > > >>> Regards,
> > > > > > >>> Saikat
> > > > > > >>>
> > > > > > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <
> > > > > saikat.maitra@gmail.com
> > > > > > >
> > > > > > >>> wrote:
> > > > > > >>>
> > > > > > >>>> Yes sure, thank you Denis
> > > > > > >>>>
> > > > > > >>>> Regards,
> > > > > > >>>> Saikat
> > > > > > >>>>
> > > > > > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <
> > dmagda@apache.org>
> > > > > > wrote:
> > > > > > >>>>
> > > > > > >>>>> Hi Saikat,
> > > > > > >>>>>
> > > > > > >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > >
> > > > >
> > > >
> > >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
> > > > > > >>>>>
> > > > > > >>>>> After that, we can return to this pending pull request.
> > > > > > >>>>>
> > > > > > >>>>> -
> > > > > > >>>>> Denis
> > > > > > >>>>>
> > > > > > >>>>>
> > > > > > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
> > > > > > >>>>> saikat.maitra@gmail.com>
> > > > > > >>>>> wrote:
> > > > > > >>>>>
> > > > > > >>>>> > Hi,
> > > > > > >>>>> >
> > > > > > >>>>> > I have raised PR for Ignite zeromq migration to Ignite
> > > > Extensions
> > > > > > >>>>> repo.
> > > > > > >>>>> >
> > > > > > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > > > > >>>>> >
> > > > > > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
> > > > > > >>>>> > https://github.com/apache/ignite/pull/7240
> > > > > > >>>>> >
> > > > > > >>>>> > Please review and share feedback.
> > > > > > >>>>> >
> > > > > > >>>>> > This is part of our Modularization effort for Streamer
> > > modules
> > > > > > >>>>> >
> > > > > > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
> > > > > > >>>>> >
> > > > > > >>>>> > Regards,
> > > > > > >>>>> > Saikat
> > > > > > >>>>> >
> > > > > > >>>>>
> > > > > > >>>>
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Denis Magda <dm...@apache.org>.
>
> In that case we should be ok to merge these 2 open PRs in master to make it
> available for 2.9.0 release.
> https://github.com/apache/ignite/pull/7240
> https://github.com/apache/ignite/pull/7227
> Can you please review and confirm?
Saikat, you are right that nothing prevents us from merging the changes to
the master that will be used to cut off a 2.9 branch in the future. Please
go ahead and your changes to the master.
As for the extensions web page, I see its structure as follows. It goes
with a header introducing the extensions repository and covering types of
contributions that are welcomed there. Then down below in the body we list
all the available extensions - it can be a simple table with an extension
name, description, URL or a bit more advanced interface with a grid layout
like on this page [1]. With the grid layout, we can add logos of the
projects Ignite is integrated with in addition to the name/description/URL.
Let me know what you think.
[1] https://ignite.apache.org/screencasts.html
-
Denis
On Sat, Apr 4, 2020 at 3:07 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hi Denis, Maxim, Ilya
>
> I observed that we already have release 2.8.1 branch
> https://github.com/apache/ignite/tree/ignite-2.8.1
>
> In that case we should be ok to merge these 2 open PRs in master to make it
> available for 2.9.0 release.
>
> https://github.com/apache/ignite/pull/7240
> https://github.com/apache/ignite/pull/7227
>
> Can you please review and confirm?
>
> Denis - I think for Ignite Extensions docs we can merge these 2 following
> pages and create a single page for Ignite extensions
>
> Streaming <https://ignite.apache.org/features/streaming.html>
> https://ignite.apache.org/features/streaming.html
> Other Integrations <https://apacheignite-mix.readme.io/docs>
> https://apacheignite-mix.readme.io/docs
>
> Let me know your thoughts.
>
> Regards,
> Saikat
>
>
> On Fri, Apr 3, 2020 at 2:46 PM Denis Magda <dm...@apache.org> wrote:
>
> > Hi Saikat,
> >
> > I believe that 2.8.x will be cut from 2.8. However, please double-check
> > with other community members posting the question here:
> >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-2-8-1-RELEASE-Time-Scope-Manager-td46452.html#a46453
> >
> > -
> > Denis
> >
> >
> > On Fri, Apr 3, 2020 at 3:05 AM Saikat Maitra <sa...@gmail.com>
> > wrote:
> >
> > > Hello Denis,
> > >
> > > Thank you for your email. I know for minor release 2.9 we will be
> cutting
> > > release branch from master.
> > >
> > > Do you know for maintenance version 2.8.x if we are cutting release
> > branch
> > > from master or are we using release branch 2.8.x and cherry picking
> fixes
> > > from master?
> > >
> > > I wanted to correctly time the merge of open PRs in master so that we
> can
> > > make changes available in 2.9 release without impacting 2.8.x versions.
> > >
> > > Regards,
> > > Saikat
> > >
> > >
> > >
> > >
> > > On Sun, Mar 29, 2020 at 5:59 PM Denis Magda <dm...@apache.org> wrote:
> > >
> > > > Hi Saikat,
> > > >
> > > > My thinking is that the removal should take place with the next minor
> > > > release 2.9. I wouldn't do this in maintenance versions such as
> 2.8.x.
> > > >
> > > > Btw, how about creating a page for Ignite extensions on the website
> > that
> > > > will be placed under "Features" menu? Would you be interested in
> that?
> > > >
> > > > -
> > > > Denis
> > > >
> > > >
> > > > On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <
> saikat.maitra@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > I wanted to discuss on merge process for PR in ignite modules when
> we
> > > are
> > > > > migrating extensions.
> > > > >
> > > > > I have created these 2 PR for ZeroMQ to migrate from ignite to
> ignite
> > > > > extension repo and also to remove ZeroMQ from ignite repo.
> > > > >
> > > > >
> > > > > https://github.com/apache/ignite-extensions/pull/5
> > > > > https://github.com/apache/ignite/pull/7240
> > > > >
> > > > > Both the PR are reviewed and in approved state and I have merged
> the
> > > > > changes for ignite-extensions.
> > > > >
> > > > > I wanted to discuss if this is right time to merge removal of
> ZeroMQ
> > > > module
> > > > > PR from ignite repo or shall I wait for initial release of
> > > > > ignite-extensions - ZeroMQ module?
> > > > >
> > > > > Regards,
> > > > > Saikat
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <
> > saikat.maitra@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Mikhail,
> > > > > >
> > > > > > Thank you for help in review. I have merged the changes.
> > > > > >
> > > > > > Regards,
> > > > > > Saikat
> > > > > >
> > > > > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <
> > > saikat.maitra@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > >> Hi Ilya, Mikhail
> > > > > >>
> > > > > >> I have updated the PR as per review comments.
> > > > > >>
> > > > > >> Please take a look and share your feedback.
> > > > > >>
> > > > > >> PR https://github.com/apache/ignite-extensions/pull/5
> > > > > >> https://github.com/apache/ignite/pull/7240
> > > > > >>
> > > > > >> Regards,
> > > > > >> Saikat
> > > > > >>
> > > > > >>
> > > > > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <
> > > > saikat.maitra@gmail.com>
> > > > > >> wrote:
> > > > > >>
> > > > > >>> Hello,
> > > > > >>>
> > > > > >>> Can someone please help in review for these following PRs. I
> have
> > > > > >>> received approval for release process from Alexey and would
> need
> > a
> > > > code
> > > > > >>> review approval for following PR.
> > > > > >>>
> > > > > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > > > >>>
> > > > > >>> PR https://github.com/apache/ignite-extensions/pull/5
> > > > > >>> https://github.com/apache/ignite/pull/7240
> > > > > >>>
> > > > > >>>
> > > > > >>> Regards,
> > > > > >>> Saikat
> > > > > >>>
> > > > > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <
> > > > saikat.maitra@gmail.com
> > > > > >
> > > > > >>> wrote:
> > > > > >>>
> > > > > >>>> Yes sure, thank you Denis
> > > > > >>>>
> > > > > >>>> Regards,
> > > > > >>>> Saikat
> > > > > >>>>
> > > > > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <
> dmagda@apache.org>
> > > > > wrote:
> > > > > >>>>
> > > > > >>>>> Hi Saikat,
> > > > > >>>>>
> > > > > >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
> > > > > >>>>>
> > > > > >>>>>
> > > > >
> > > >
> > >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
> > > > > >>>>>
> > > > > >>>>> After that, we can return to this pending pull request.
> > > > > >>>>>
> > > > > >>>>> -
> > > > > >>>>> Denis
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
> > > > > >>>>> saikat.maitra@gmail.com>
> > > > > >>>>> wrote:
> > > > > >>>>>
> > > > > >>>>> > Hi,
> > > > > >>>>> >
> > > > > >>>>> > I have raised PR for Ignite zeromq migration to Ignite
> > > Extensions
> > > > > >>>>> repo.
> > > > > >>>>> >
> > > > > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > > > >>>>> >
> > > > > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
> > > > > >>>>> > https://github.com/apache/ignite/pull/7240
> > > > > >>>>> >
> > > > > >>>>> > Please review and share feedback.
> > > > > >>>>> >
> > > > > >>>>> > This is part of our Modularization effort for Streamer
> > modules
> > > > > >>>>> >
> > > > > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
> > > > > >>>>> >
> > > > > >>>>> > Regards,
> > > > > >>>>> > Saikat
> > > > > >>>>> >
> > > > > >>>>>
> > > > > >>>>
> > > > >
> > > >
> > >
> >
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hi,
I have posted my query here in 2.8.1 release thread:
http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-2-8-1-RELEASE-Time-Scope-Manager-td46452i20.html#a46833
Regards,
Saikat
On Sat, Apr 4, 2020 at 5:06 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hi Denis, Maxim, Ilya
>
> I observed that we already have release 2.8.1 branch
> https://github.com/apache/ignite/tree/ignite-2.8.1
>
> In that case we should be ok to merge these 2 open PRs in master to make
> it available for 2.9.0 release.
>
> https://github.com/apache/ignite/pull/7240
> https://github.com/apache/ignite/pull/7227
>
> Can you please review and confirm?
>
> Denis - I think for Ignite Extensions docs we can merge these 2 following
> pages and create a single page for Ignite extensions
>
> Streaming <https://ignite.apache.org/features/streaming.html>
> https://ignite.apache.org/features/streaming.html
> Other Integrations <https://apacheignite-mix.readme.io/docs>
> https://apacheignite-mix.readme.io/docs
>
> Let me know your thoughts.
>
> Regards,
> Saikat
>
>
> On Fri, Apr 3, 2020 at 2:46 PM Denis Magda <dm...@apache.org> wrote:
>
>> Hi Saikat,
>>
>> I believe that 2.8.x will be cut from 2.8. However, please double-check
>> with other community members posting the question here:
>>
>> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-2-8-1-RELEASE-Time-Scope-Manager-td46452.html#a46453
>>
>> -
>> Denis
>>
>>
>> On Fri, Apr 3, 2020 at 3:05 AM Saikat Maitra <sa...@gmail.com>
>> wrote:
>>
>> > Hello Denis,
>> >
>> > Thank you for your email. I know for minor release 2.9 we will be
>> cutting
>> > release branch from master.
>> >
>> > Do you know for maintenance version 2.8.x if we are cutting release
>> branch
>> > from master or are we using release branch 2.8.x and cherry picking
>> fixes
>> > from master?
>> >
>> > I wanted to correctly time the merge of open PRs in master so that we
>> can
>> > make changes available in 2.9 release without impacting 2.8.x versions.
>> >
>> > Regards,
>> > Saikat
>> >
>> >
>> >
>> >
>> > On Sun, Mar 29, 2020 at 5:59 PM Denis Magda <dm...@apache.org> wrote:
>> >
>> > > Hi Saikat,
>> > >
>> > > My thinking is that the removal should take place with the next minor
>> > > release 2.9. I wouldn't do this in maintenance versions such as 2.8.x.
>> > >
>> > > Btw, how about creating a page for Ignite extensions on the website
>> that
>> > > will be placed under "Features" menu? Would you be interested in that?
>> > >
>> > > -
>> > > Denis
>> > >
>> > >
>> > > On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <
>> saikat.maitra@gmail.com>
>> > > wrote:
>> > >
>> > > > Hello,
>> > > >
>> > > > I wanted to discuss on merge process for PR in ignite modules when
>> we
>> > are
>> > > > migrating extensions.
>> > > >
>> > > > I have created these 2 PR for ZeroMQ to migrate from ignite to
>> ignite
>> > > > extension repo and also to remove ZeroMQ from ignite repo.
>> > > >
>> > > >
>> > > > https://github.com/apache/ignite-extensions/pull/5
>> > > > https://github.com/apache/ignite/pull/7240
>> > > >
>> > > > Both the PR are reviewed and in approved state and I have merged the
>> > > > changes for ignite-extensions.
>> > > >
>> > > > I wanted to discuss if this is right time to merge removal of ZeroMQ
>> > > module
>> > > > PR from ignite repo or shall I wait for initial release of
>> > > > ignite-extensions - ZeroMQ module?
>> > > >
>> > > > Regards,
>> > > > Saikat
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <
>> saikat.maitra@gmail.com
>> > >
>> > > > wrote:
>> > > >
>> > > > > Hi Mikhail,
>> > > > >
>> > > > > Thank you for help in review. I have merged the changes.
>> > > > >
>> > > > > Regards,
>> > > > > Saikat
>> > > > >
>> > > > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <
>> > saikat.maitra@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > >> Hi Ilya, Mikhail
>> > > > >>
>> > > > >> I have updated the PR as per review comments.
>> > > > >>
>> > > > >> Please take a look and share your feedback.
>> > > > >>
>> > > > >> PR https://github.com/apache/ignite-extensions/pull/5
>> > > > >> https://github.com/apache/ignite/pull/7240
>> > > > >>
>> > > > >> Regards,
>> > > > >> Saikat
>> > > > >>
>> > > > >>
>> > > > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <
>> > > saikat.maitra@gmail.com>
>> > > > >> wrote:
>> > > > >>
>> > > > >>> Hello,
>> > > > >>>
>> > > > >>> Can someone please help in review for these following PRs. I
>> have
>> > > > >>> received approval for release process from Alexey and would
>> need a
>> > > code
>> > > > >>> review approval for following PR.
>> > > > >>>
>> > > > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
>> > > > >>>
>> > > > >>> PR https://github.com/apache/ignite-extensions/pull/5
>> > > > >>> https://github.com/apache/ignite/pull/7240
>> > > > >>>
>> > > > >>>
>> > > > >>> Regards,
>> > > > >>> Saikat
>> > > > >>>
>> > > > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <
>> > > saikat.maitra@gmail.com
>> > > > >
>> > > > >>> wrote:
>> > > > >>>
>> > > > >>>> Yes sure, thank you Denis
>> > > > >>>>
>> > > > >>>> Regards,
>> > > > >>>> Saikat
>> > > > >>>>
>> > > > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dmagda@apache.org
>> >
>> > > > wrote:
>> > > > >>>>
>> > > > >>>>> Hi Saikat,
>> > > > >>>>>
>> > > > >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
>> > > > >>>>>
>> > > > >>>>>
>> > > >
>> > >
>> >
>> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
>> > > > >>>>>
>> > > > >>>>> After that, we can return to this pending pull request.
>> > > > >>>>>
>> > > > >>>>> -
>> > > > >>>>> Denis
>> > > > >>>>>
>> > > > >>>>>
>> > > > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
>> > > > >>>>> saikat.maitra@gmail.com>
>> > > > >>>>> wrote:
>> > > > >>>>>
>> > > > >>>>> > Hi,
>> > > > >>>>> >
>> > > > >>>>> > I have raised PR for Ignite zeromq migration to Ignite
>> > Extensions
>> > > > >>>>> repo.
>> > > > >>>>> >
>> > > > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
>> > > > >>>>> >
>> > > > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
>> > > > >>>>> > https://github.com/apache/ignite/pull/7240
>> > > > >>>>> >
>> > > > >>>>> > Please review and share feedback.
>> > > > >>>>> >
>> > > > >>>>> > This is part of our Modularization effort for Streamer
>> modules
>> > > > >>>>> >
>> > > > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
>> > > > >>>>> >
>> > > > >>>>> > Regards,
>> > > > >>>>> > Saikat
>> > > > >>>>> >
>> > > > >>>>>
>> > > > >>>>
>> > > >
>> > >
>> >
>>
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hi Denis, Maxim, Ilya
I observed that we already have release 2.8.1 branch
https://github.com/apache/ignite/tree/ignite-2.8.1
In that case we should be ok to merge these 2 open PRs in master to make it
available for 2.9.0 release.
https://github.com/apache/ignite/pull/7240
https://github.com/apache/ignite/pull/7227
Can you please review and confirm?
Denis - I think for Ignite Extensions docs we can merge these 2 following
pages and create a single page for Ignite extensions
Streaming <https://ignite.apache.org/features/streaming.html>
https://ignite.apache.org/features/streaming.html
Other Integrations <https://apacheignite-mix.readme.io/docs>
https://apacheignite-mix.readme.io/docs
Let me know your thoughts.
Regards,
Saikat
On Fri, Apr 3, 2020 at 2:46 PM Denis Magda <dm...@apache.org> wrote:
> Hi Saikat,
>
> I believe that 2.8.x will be cut from 2.8. However, please double-check
> with other community members posting the question here:
>
> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-2-8-1-RELEASE-Time-Scope-Manager-td46452.html#a46453
>
> -
> Denis
>
>
> On Fri, Apr 3, 2020 at 3:05 AM Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Hello Denis,
> >
> > Thank you for your email. I know for minor release 2.9 we will be cutting
> > release branch from master.
> >
> > Do you know for maintenance version 2.8.x if we are cutting release
> branch
> > from master or are we using release branch 2.8.x and cherry picking fixes
> > from master?
> >
> > I wanted to correctly time the merge of open PRs in master so that we can
> > make changes available in 2.9 release without impacting 2.8.x versions.
> >
> > Regards,
> > Saikat
> >
> >
> >
> >
> > On Sun, Mar 29, 2020 at 5:59 PM Denis Magda <dm...@apache.org> wrote:
> >
> > > Hi Saikat,
> > >
> > > My thinking is that the removal should take place with the next minor
> > > release 2.9. I wouldn't do this in maintenance versions such as 2.8.x.
> > >
> > > Btw, how about creating a page for Ignite extensions on the website
> that
> > > will be placed under "Features" menu? Would you be interested in that?
> > >
> > > -
> > > Denis
> > >
> > >
> > > On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <saikat.maitra@gmail.com
> >
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > I wanted to discuss on merge process for PR in ignite modules when we
> > are
> > > > migrating extensions.
> > > >
> > > > I have created these 2 PR for ZeroMQ to migrate from ignite to ignite
> > > > extension repo and also to remove ZeroMQ from ignite repo.
> > > >
> > > >
> > > > https://github.com/apache/ignite-extensions/pull/5
> > > > https://github.com/apache/ignite/pull/7240
> > > >
> > > > Both the PR are reviewed and in approved state and I have merged the
> > > > changes for ignite-extensions.
> > > >
> > > > I wanted to discuss if this is right time to merge removal of ZeroMQ
> > > module
> > > > PR from ignite repo or shall I wait for initial release of
> > > > ignite-extensions - ZeroMQ module?
> > > >
> > > > Regards,
> > > > Saikat
> > > >
> > > >
> > > >
> > > >
> > > > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <
> saikat.maitra@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi Mikhail,
> > > > >
> > > > > Thank you for help in review. I have merged the changes.
> > > > >
> > > > > Regards,
> > > > > Saikat
> > > > >
> > > > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <
> > saikat.maitra@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> Hi Ilya, Mikhail
> > > > >>
> > > > >> I have updated the PR as per review comments.
> > > > >>
> > > > >> Please take a look and share your feedback.
> > > > >>
> > > > >> PR https://github.com/apache/ignite-extensions/pull/5
> > > > >> https://github.com/apache/ignite/pull/7240
> > > > >>
> > > > >> Regards,
> > > > >> Saikat
> > > > >>
> > > > >>
> > > > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <
> > > saikat.maitra@gmail.com>
> > > > >> wrote:
> > > > >>
> > > > >>> Hello,
> > > > >>>
> > > > >>> Can someone please help in review for these following PRs. I have
> > > > >>> received approval for release process from Alexey and would need
> a
> > > code
> > > > >>> review approval for following PR.
> > > > >>>
> > > > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > > >>>
> > > > >>> PR https://github.com/apache/ignite-extensions/pull/5
> > > > >>> https://github.com/apache/ignite/pull/7240
> > > > >>>
> > > > >>>
> > > > >>> Regards,
> > > > >>> Saikat
> > > > >>>
> > > > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <
> > > saikat.maitra@gmail.com
> > > > >
> > > > >>> wrote:
> > > > >>>
> > > > >>>> Yes sure, thank you Denis
> > > > >>>>
> > > > >>>> Regards,
> > > > >>>> Saikat
> > > > >>>>
> > > > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org>
> > > > wrote:
> > > > >>>>
> > > > >>>>> Hi Saikat,
> > > > >>>>>
> > > > >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
> > > > >>>>>
> > > > >>>>>
> > > >
> > >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
> > > > >>>>>
> > > > >>>>> After that, we can return to this pending pull request.
> > > > >>>>>
> > > > >>>>> -
> > > > >>>>> Denis
> > > > >>>>>
> > > > >>>>>
> > > > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
> > > > >>>>> saikat.maitra@gmail.com>
> > > > >>>>> wrote:
> > > > >>>>>
> > > > >>>>> > Hi,
> > > > >>>>> >
> > > > >>>>> > I have raised PR for Ignite zeromq migration to Ignite
> > Extensions
> > > > >>>>> repo.
> > > > >>>>> >
> > > > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > > >>>>> >
> > > > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
> > > > >>>>> > https://github.com/apache/ignite/pull/7240
> > > > >>>>> >
> > > > >>>>> > Please review and share feedback.
> > > > >>>>> >
> > > > >>>>> > This is part of our Modularization effort for Streamer
> modules
> > > > >>>>> >
> > > > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
> > > > >>>>> >
> > > > >>>>> > Regards,
> > > > >>>>> > Saikat
> > > > >>>>> >
> > > > >>>>>
> > > > >>>>
> > > >
> > >
> >
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Denis Magda <dm...@apache.org>.
Hi Saikat,
I believe that 2.8.x will be cut from 2.8. However, please double-check
with other community members posting the question here:
http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-2-8-1-RELEASE-Time-Scope-Manager-td46452.html#a46453
-
Denis
On Fri, Apr 3, 2020 at 3:05 AM Saikat Maitra <sa...@gmail.com>
wrote:
> Hello Denis,
>
> Thank you for your email. I know for minor release 2.9 we will be cutting
> release branch from master.
>
> Do you know for maintenance version 2.8.x if we are cutting release branch
> from master or are we using release branch 2.8.x and cherry picking fixes
> from master?
>
> I wanted to correctly time the merge of open PRs in master so that we can
> make changes available in 2.9 release without impacting 2.8.x versions.
>
> Regards,
> Saikat
>
>
>
>
> On Sun, Mar 29, 2020 at 5:59 PM Denis Magda <dm...@apache.org> wrote:
>
> > Hi Saikat,
> >
> > My thinking is that the removal should take place with the next minor
> > release 2.9. I wouldn't do this in maintenance versions such as 2.8.x.
> >
> > Btw, how about creating a page for Ignite extensions on the website that
> > will be placed under "Features" menu? Would you be interested in that?
> >
> > -
> > Denis
> >
> >
> > On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <sa...@gmail.com>
> > wrote:
> >
> > > Hello,
> > >
> > > I wanted to discuss on merge process for PR in ignite modules when we
> are
> > > migrating extensions.
> > >
> > > I have created these 2 PR for ZeroMQ to migrate from ignite to ignite
> > > extension repo and also to remove ZeroMQ from ignite repo.
> > >
> > >
> > > https://github.com/apache/ignite-extensions/pull/5
> > > https://github.com/apache/ignite/pull/7240
> > >
> > > Both the PR are reviewed and in approved state and I have merged the
> > > changes for ignite-extensions.
> > >
> > > I wanted to discuss if this is right time to merge removal of ZeroMQ
> > module
> > > PR from ignite repo or shall I wait for initial release of
> > > ignite-extensions - ZeroMQ module?
> > >
> > > Regards,
> > > Saikat
> > >
> > >
> > >
> > >
> > > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <saikat.maitra@gmail.com
> >
> > > wrote:
> > >
> > > > Hi Mikhail,
> > > >
> > > > Thank you for help in review. I have merged the changes.
> > > >
> > > > Regards,
> > > > Saikat
> > > >
> > > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <
> saikat.maitra@gmail.com>
> > > > wrote:
> > > >
> > > >> Hi Ilya, Mikhail
> > > >>
> > > >> I have updated the PR as per review comments.
> > > >>
> > > >> Please take a look and share your feedback.
> > > >>
> > > >> PR https://github.com/apache/ignite-extensions/pull/5
> > > >> https://github.com/apache/ignite/pull/7240
> > > >>
> > > >> Regards,
> > > >> Saikat
> > > >>
> > > >>
> > > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <
> > saikat.maitra@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> Hello,
> > > >>>
> > > >>> Can someone please help in review for these following PRs. I have
> > > >>> received approval for release process from Alexey and would need a
> > code
> > > >>> review approval for following PR.
> > > >>>
> > > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > >>>
> > > >>> PR https://github.com/apache/ignite-extensions/pull/5
> > > >>> https://github.com/apache/ignite/pull/7240
> > > >>>
> > > >>>
> > > >>> Regards,
> > > >>> Saikat
> > > >>>
> > > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <
> > saikat.maitra@gmail.com
> > > >
> > > >>> wrote:
> > > >>>
> > > >>>> Yes sure, thank you Denis
> > > >>>>
> > > >>>> Regards,
> > > >>>> Saikat
> > > >>>>
> > > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org>
> > > wrote:
> > > >>>>
> > > >>>>> Hi Saikat,
> > > >>>>>
> > > >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
> > > >>>>>
> > > >>>>>
> > >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
> > > >>>>>
> > > >>>>> After that, we can return to this pending pull request.
> > > >>>>>
> > > >>>>> -
> > > >>>>> Denis
> > > >>>>>
> > > >>>>>
> > > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
> > > >>>>> saikat.maitra@gmail.com>
> > > >>>>> wrote:
> > > >>>>>
> > > >>>>> > Hi,
> > > >>>>> >
> > > >>>>> > I have raised PR for Ignite zeromq migration to Ignite
> Extensions
> > > >>>>> repo.
> > > >>>>> >
> > > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > > >>>>> >
> > > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
> > > >>>>> > https://github.com/apache/ignite/pull/7240
> > > >>>>> >
> > > >>>>> > Please review and share feedback.
> > > >>>>> >
> > > >>>>> > This is part of our Modularization effort for Streamer modules
> > > >>>>> >
> > > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
> > > >>>>> >
> > > >>>>> > Regards,
> > > >>>>> > Saikat
> > > >>>>> >
> > > >>>>>
> > > >>>>
> > >
> >
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hello Denis,
Thank you for your email. I know for minor release 2.9 we will be cutting
release branch from master.
Do you know for maintenance version 2.8.x if we are cutting release branch
from master or are we using release branch 2.8.x and cherry picking fixes
from master?
I wanted to correctly time the merge of open PRs in master so that we can
make changes available in 2.9 release without impacting 2.8.x versions.
Regards,
Saikat
On Sun, Mar 29, 2020 at 5:59 PM Denis Magda <dm...@apache.org> wrote:
> Hi Saikat,
>
> My thinking is that the removal should take place with the next minor
> release 2.9. I wouldn't do this in maintenance versions such as 2.8.x.
>
> Btw, how about creating a page for Ignite extensions on the website that
> will be placed under "Features" menu? Would you be interested in that?
>
> -
> Denis
>
>
> On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Hello,
> >
> > I wanted to discuss on merge process for PR in ignite modules when we are
> > migrating extensions.
> >
> > I have created these 2 PR for ZeroMQ to migrate from ignite to ignite
> > extension repo and also to remove ZeroMQ from ignite repo.
> >
> >
> > https://github.com/apache/ignite-extensions/pull/5
> > https://github.com/apache/ignite/pull/7240
> >
> > Both the PR are reviewed and in approved state and I have merged the
> > changes for ignite-extensions.
> >
> > I wanted to discuss if this is right time to merge removal of ZeroMQ
> module
> > PR from ignite repo or shall I wait for initial release of
> > ignite-extensions - ZeroMQ module?
> >
> > Regards,
> > Saikat
> >
> >
> >
> >
> > On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <sa...@gmail.com>
> > wrote:
> >
> > > Hi Mikhail,
> > >
> > > Thank you for help in review. I have merged the changes.
> > >
> > > Regards,
> > > Saikat
> > >
> > > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <sa...@gmail.com>
> > > wrote:
> > >
> > >> Hi Ilya, Mikhail
> > >>
> > >> I have updated the PR as per review comments.
> > >>
> > >> Please take a look and share your feedback.
> > >>
> > >> PR https://github.com/apache/ignite-extensions/pull/5
> > >> https://github.com/apache/ignite/pull/7240
> > >>
> > >> Regards,
> > >> Saikat
> > >>
> > >>
> > >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <
> saikat.maitra@gmail.com>
> > >> wrote:
> > >>
> > >>> Hello,
> > >>>
> > >>> Can someone please help in review for these following PRs. I have
> > >>> received approval for release process from Alexey and would need a
> code
> > >>> review approval for following PR.
> > >>>
> > >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > >>>
> > >>> PR https://github.com/apache/ignite-extensions/pull/5
> > >>> https://github.com/apache/ignite/pull/7240
> > >>>
> > >>>
> > >>> Regards,
> > >>> Saikat
> > >>>
> > >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <
> saikat.maitra@gmail.com
> > >
> > >>> wrote:
> > >>>
> > >>>> Yes sure, thank you Denis
> > >>>>
> > >>>> Regards,
> > >>>> Saikat
> > >>>>
> > >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org>
> > wrote:
> > >>>>
> > >>>>> Hi Saikat,
> > >>>>>
> > >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
> > >>>>>
> > >>>>>
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
> > >>>>>
> > >>>>> After that, we can return to this pending pull request.
> > >>>>>
> > >>>>> -
> > >>>>> Denis
> > >>>>>
> > >>>>>
> > >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
> > >>>>> saikat.maitra@gmail.com>
> > >>>>> wrote:
> > >>>>>
> > >>>>> > Hi,
> > >>>>> >
> > >>>>> > I have raised PR for Ignite zeromq migration to Ignite Extensions
> > >>>>> repo.
> > >>>>> >
> > >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> > >>>>> >
> > >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
> > >>>>> > https://github.com/apache/ignite/pull/7240
> > >>>>> >
> > >>>>> > Please review and share feedback.
> > >>>>> >
> > >>>>> > This is part of our Modularization effort for Streamer modules
> > >>>>> >
> > >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
> > >>>>> >
> > >>>>> > Regards,
> > >>>>> > Saikat
> > >>>>> >
> > >>>>>
> > >>>>
> >
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Denis Magda <dm...@apache.org>.
Hi Saikat,
My thinking is that the removal should take place with the next minor
release 2.9. I wouldn't do this in maintenance versions such as 2.8.x.
Btw, how about creating a page for Ignite extensions on the website that
will be placed under "Features" menu? Would you be interested in that?
-
Denis
On Fri, Mar 27, 2020 at 4:21 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hello,
>
> I wanted to discuss on merge process for PR in ignite modules when we are
> migrating extensions.
>
> I have created these 2 PR for ZeroMQ to migrate from ignite to ignite
> extension repo and also to remove ZeroMQ from ignite repo.
>
>
> https://github.com/apache/ignite-extensions/pull/5
> https://github.com/apache/ignite/pull/7240
>
> Both the PR are reviewed and in approved state and I have merged the
> changes for ignite-extensions.
>
> I wanted to discuss if this is right time to merge removal of ZeroMQ module
> PR from ignite repo or shall I wait for initial release of
> ignite-extensions - ZeroMQ module?
>
> Regards,
> Saikat
>
>
>
>
> On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Hi Mikhail,
> >
> > Thank you for help in review. I have merged the changes.
> >
> > Regards,
> > Saikat
> >
> > On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <sa...@gmail.com>
> > wrote:
> >
> >> Hi Ilya, Mikhail
> >>
> >> I have updated the PR as per review comments.
> >>
> >> Please take a look and share your feedback.
> >>
> >> PR https://github.com/apache/ignite-extensions/pull/5
> >> https://github.com/apache/ignite/pull/7240
> >>
> >> Regards,
> >> Saikat
> >>
> >>
> >> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <sa...@gmail.com>
> >> wrote:
> >>
> >>> Hello,
> >>>
> >>> Can someone please help in review for these following PRs. I have
> >>> received approval for release process from Alexey and would need a code
> >>> review approval for following PR.
> >>>
> >>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
> >>>
> >>> PR https://github.com/apache/ignite-extensions/pull/5
> >>> https://github.com/apache/ignite/pull/7240
> >>>
> >>>
> >>> Regards,
> >>> Saikat
> >>>
> >>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <saikat.maitra@gmail.com
> >
> >>> wrote:
> >>>
> >>>> Yes sure, thank you Denis
> >>>>
> >>>> Regards,
> >>>> Saikat
> >>>>
> >>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org>
> wrote:
> >>>>
> >>>>> Hi Saikat,
> >>>>>
> >>>>> Let's wait while Alex Goncharuk checks a similar PR here:
> >>>>>
> >>>>>
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
> >>>>>
> >>>>> After that, we can return to this pending pull request.
> >>>>>
> >>>>> -
> >>>>> Denis
> >>>>>
> >>>>>
> >>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
> >>>>> saikat.maitra@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>> > Hi,
> >>>>> >
> >>>>> > I have raised PR for Ignite zeromq migration to Ignite Extensions
> >>>>> repo.
> >>>>> >
> >>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> >>>>> >
> >>>>> > PR https://github.com/apache/ignite-extensions/pull/5
> >>>>> > https://github.com/apache/ignite/pull/7240
> >>>>> >
> >>>>> > Please review and share feedback.
> >>>>> >
> >>>>> > This is part of our Modularization effort for Streamer modules
> >>>>> >
> >>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
> >>>>> >
> >>>>> > Regards,
> >>>>> > Saikat
> >>>>> >
> >>>>>
> >>>>
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hello,
I wanted to discuss on merge process for PR in ignite modules when we are
migrating extensions.
I have created these 2 PR for ZeroMQ to migrate from ignite to ignite
extension repo and also to remove ZeroMQ from ignite repo.
https://github.com/apache/ignite-extensions/pull/5
https://github.com/apache/ignite/pull/7240
Both the PR are reviewed and in approved state and I have merged the
changes for ignite-extensions.
I wanted to discuss if this is right time to merge removal of ZeroMQ module
PR from ignite repo or shall I wait for initial release of
ignite-extensions - ZeroMQ module?
Regards,
Saikat
On Fri, Mar 27, 2020 at 6:11 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hi Mikhail,
>
> Thank you for help in review. I have merged the changes.
>
> Regards,
> Saikat
>
> On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
>> Hi Ilya, Mikhail
>>
>> I have updated the PR as per review comments.
>>
>> Please take a look and share your feedback.
>>
>> PR https://github.com/apache/ignite-extensions/pull/5
>> https://github.com/apache/ignite/pull/7240
>>
>> Regards,
>> Saikat
>>
>>
>> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <sa...@gmail.com>
>> wrote:
>>
>>> Hello,
>>>
>>> Can someone please help in review for these following PRs. I have
>>> received approval for release process from Alexey and would need a code
>>> review approval for following PR.
>>>
>>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
>>>
>>> PR https://github.com/apache/ignite-extensions/pull/5
>>> https://github.com/apache/ignite/pull/7240
>>>
>>>
>>> Regards,
>>> Saikat
>>>
>>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <sa...@gmail.com>
>>> wrote:
>>>
>>>> Yes sure, thank you Denis
>>>>
>>>> Regards,
>>>> Saikat
>>>>
>>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org> wrote:
>>>>
>>>>> Hi Saikat,
>>>>>
>>>>> Let's wait while Alex Goncharuk checks a similar PR here:
>>>>>
>>>>> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
>>>>>
>>>>> After that, we can return to this pending pull request.
>>>>>
>>>>> -
>>>>> Denis
>>>>>
>>>>>
>>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <
>>>>> saikat.maitra@gmail.com>
>>>>> wrote:
>>>>>
>>>>> > Hi,
>>>>> >
>>>>> > I have raised PR for Ignite zeromq migration to Ignite Extensions
>>>>> repo.
>>>>> >
>>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
>>>>> >
>>>>> > PR https://github.com/apache/ignite-extensions/pull/5
>>>>> > https://github.com/apache/ignite/pull/7240
>>>>> >
>>>>> > Please review and share feedback.
>>>>> >
>>>>> > This is part of our Modularization effort for Streamer modules
>>>>> >
>>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
>>>>> >
>>>>> > Regards,
>>>>> > Saikat
>>>>> >
>>>>>
>>>>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hi Mikhail,
Thank you for help in review. I have merged the changes.
Regards,
Saikat
On Sun, Mar 8, 2020 at 1:39 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hi Ilya, Mikhail
>
> I have updated the PR as per review comments.
>
> Please take a look and share your feedback.
>
> PR https://github.com/apache/ignite-extensions/pull/5
> https://github.com/apache/ignite/pull/7240
>
> Regards,
> Saikat
>
>
> On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
>> Hello,
>>
>> Can someone please help in review for these following PRs. I have
>> received approval for release process from Alexey and would need a code
>> review approval for following PR.
>>
>> Jira https://issues.apache.org/jira/browse/IGNITE-12358
>>
>> PR https://github.com/apache/ignite-extensions/pull/5
>> https://github.com/apache/ignite/pull/7240
>>
>>
>> Regards,
>> Saikat
>>
>> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <sa...@gmail.com>
>> wrote:
>>
>>> Yes sure, thank you Denis
>>>
>>> Regards,
>>> Saikat
>>>
>>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org> wrote:
>>>
>>>> Hi Saikat,
>>>>
>>>> Let's wait while Alex Goncharuk checks a similar PR here:
>>>>
>>>> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
>>>>
>>>> After that, we can return to this pending pull request.
>>>>
>>>> -
>>>> Denis
>>>>
>>>>
>>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <saikat.maitra@gmail.com
>>>> >
>>>> wrote:
>>>>
>>>> > Hi,
>>>> >
>>>> > I have raised PR for Ignite zeromq migration to Ignite Extensions
>>>> repo.
>>>> >
>>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
>>>> >
>>>> > PR https://github.com/apache/ignite-extensions/pull/5
>>>> > https://github.com/apache/ignite/pull/7240
>>>> >
>>>> > Please review and share feedback.
>>>> >
>>>> > This is part of our Modularization effort for Streamer modules
>>>> >
>>>> > https://issues.apache.org/jira/browse/IGNITE-12355
>>>> >
>>>> > Regards,
>>>> > Saikat
>>>> >
>>>>
>>>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hi Ilya, Mikhail
I have updated the PR as per review comments.
Please take a look and share your feedback.
PR https://github.com/apache/ignite-extensions/pull/5
https://github.com/apache/ignite/pull/7240
Regards,
Saikat
On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hello,
>
> Can someone please help in review for these following PRs. I have
> received approval for release process from Alexey and would need a code
> review approval for following PR.
>
> Jira https://issues.apache.org/jira/browse/IGNITE-12358
>
> PR https://github.com/apache/ignite-extensions/pull/5
> https://github.com/apache/ignite/pull/7240
>
>
> Regards,
> Saikat
>
> On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
>> Yes sure, thank you Denis
>>
>> Regards,
>> Saikat
>>
>> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org> wrote:
>>
>>> Hi Saikat,
>>>
>>> Let's wait while Alex Goncharuk checks a similar PR here:
>>>
>>> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
>>>
>>> After that, we can return to this pending pull request.
>>>
>>> -
>>> Denis
>>>
>>>
>>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <sa...@gmail.com>
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > I have raised PR for Ignite zeromq migration to Ignite Extensions repo.
>>> >
>>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
>>> >
>>> > PR https://github.com/apache/ignite-extensions/pull/5
>>> > https://github.com/apache/ignite/pull/7240
>>> >
>>> > Please review and share feedback.
>>> >
>>> > This is part of our Modularization effort for Streamer modules
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-12355
>>> >
>>> > Regards,
>>> > Saikat
>>> >
>>>
>>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Hello,
Can someone please help in review for these following PRs. I have
received approval for release process from Alexey and would need a code
review approval for following PR.
Jira https://issues.apache.org/jira/browse/IGNITE-12358
PR https://github.com/apache/ignite-extensions/pull/5
https://github.com/apache/ignite/pull/7240
Regards,
Saikat
On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Yes sure, thank you Denis
>
> Regards,
> Saikat
>
> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org> wrote:
>
>> Hi Saikat,
>>
>> Let's wait while Alex Goncharuk checks a similar PR here:
>>
>> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
>>
>> After that, we can return to this pending pull request.
>>
>> -
>> Denis
>>
>>
>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <sa...@gmail.com>
>> wrote:
>>
>> > Hi,
>> >
>> > I have raised PR for Ignite zeromq migration to Ignite Extensions repo.
>> >
>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
>> >
>> > PR https://github.com/apache/ignite-extensions/pull/5
>> > https://github.com/apache/ignite/pull/7240
>> >
>> > Please review and share feedback.
>> >
>> > This is part of our Modularization effort for Streamer modules
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-12355
>> >
>> > Regards,
>> > Saikat
>> >
>>
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Saikat Maitra <sa...@gmail.com>.
Yes sure, thank you Denis
Regards,
Saikat
On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dm...@apache.org> wrote:
> Hi Saikat,
>
> Let's wait while Alex Goncharuk checks a similar PR here:
>
> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
>
> After that, we can return to this pending pull request.
>
> -
> Denis
>
>
> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Hi,
> >
> > I have raised PR for Ignite zeromq migration to Ignite Extensions repo.
> >
> > Jira https://issues.apache.org/jira/browse/IGNITE-12358
> >
> > PR https://github.com/apache/ignite-extensions/pull/5
> > https://github.com/apache/ignite/pull/7240
> >
> > Please review and share feedback.
> >
> > This is part of our Modularization effort for Streamer modules
> >
> > https://issues.apache.org/jira/browse/IGNITE-12355
> >
> > Regards,
> > Saikat
> >
>
Re: IGNITE-12358 Migrate ZeroMQ module to ignite-extensions
Posted by Denis Magda <dm...@apache.org>.
Hi Saikat,
Let's wait while Alex Goncharuk checks a similar PR here:
http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html
After that, we can return to this pending pull request.
-
Denis
On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <sa...@gmail.com>
wrote:
> Hi,
>
> I have raised PR for Ignite zeromq migration to Ignite Extensions repo.
>
> Jira https://issues.apache.org/jira/browse/IGNITE-12358
>
> PR https://github.com/apache/ignite-extensions/pull/5
> https://github.com/apache/ignite/pull/7240
>
> Please review and share feedback.
>
> This is part of our Modularization effort for Streamer modules
>
> https://issues.apache.org/jira/browse/IGNITE-12355
>
> Regards,
> Saikat
>