You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/11 03:05:12 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #16492: [improve][cleanup] Keep usage of deprecated configs inside ServiceConfiguration

tisonkun commented on code in PR #16492:
URL: https://github.com/apache/pulsar/pull/16492#discussion_r917509180


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2779,6 +2781,10 @@ public class ServiceConfiguration implements PulsarConfiguration {
     )
     private Set<String> additionalServlets = new TreeSet<>();
 
+    public boolean isSubscriptionKeySharedEnable() {
+        return subscriptionKeySharedEnable && subscriptionTypesEnabled.contains("Key_Shared");
+    }

Review Comment:
   I'm glad to do so. Shall I separate the bug fix into a new PR or join in this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org