You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HaoYang670 (via GitHub)" <gi...@apache.org> on 2023/02/12 03:39:06 UTC
[GitHub] [arrow-datafusion] HaoYang670 opened a new pull request, #5257: enhance the checking of type errors in the test `window_frame_creation`
HaoYang670 opened a new pull request, #5257:
URL: https://github.com/apache/arrow-datafusion/pull/5257
Signed-off-by: remzi <13...@gmail.com>
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
None.
Related to #4685.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
We should test the type errors in a query could be detected from either the logical plan (skip_failed_rules = false) or the physical plan (skip_failed_rules = true).
# What changes are included in this PR?
Only update the test.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5257: enhance the checking of type errors in the test `window_frame_creation`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5257:
URL: https://github.com/apache/arrow-datafusion/pull/5257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on pull request #5257: enhance the checking of type errors in the test `window_frame_creation`
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #5257:
URL: https://github.com/apache/arrow-datafusion/pull/5257#issuecomment-1426934566
@jackwener @alamb could you please help to review? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mustafasrepo commented on pull request #5257: enhance the checking of type errors in the test `window_frame_creation`
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on PR #5257:
URL: https://github.com/apache/arrow-datafusion/pull/5257#issuecomment-1427769680
LGTM!. This enables us to add tests for skipped errors. Thank you @HaoYang670.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5257: enhance the checking of type errors in the test `window_frame_creation`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5257:
URL: https://github.com/apache/arrow-datafusion/pull/5257#issuecomment-1427837762
Benchmark runs are scheduled for baseline = 016ad8ee5ab0797b2ce467a05844ba0c6da7ecbc and contender = 3da790214ea479626eb4114c53440dc17b737d54. 3da790214ea479626eb4114c53440dc17b737d54 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4281232f43e34a3e8f56e8b15f8477ca...e074935e3a4546caad785d5db4fd866c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/249e80df9eae481092a4139b889d79dc...735ec441b35743cfa7036367a5a4899b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/30493a2239544b4d9a48f02cf2bee13d...6db42e6f7cf04940a1388e97c9aa8005/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b81b5e506d634f7991e35acb547c6b04...8588c39f501445c780a102458e2c9377/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org