You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/13 18:53:59 UTC

[GitHub] [hbase] joshelser commented on a change in pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…

joshelser commented on a change in pull request #2878:
URL: https://github.com/apache/hbase/pull/2878#discussion_r556755329



##########
File path: hbase-common/src/main/resources/hbase-default.xml
##########
@@ -1461,15 +1461,15 @@ possible configurations would overwhelm and obscure the important.
   </property>
   <property>
     <name>dfs.client.read.shortcircuit</name>
-    <value>false</value>
+    <value></value>

Review comment:
       hdfs-site.xml should be taking precedence over this property (I had a similar question about dfs.domain.socket.path) and this shouldn't be an issue in real life.
   
   However, I would also be ok coming back and just dropping these entries entirely in the future :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org