You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/03/12 21:17:25 UTC
[GitHub] gandhirajan commented on a change in pull request #804: CB-13964 - 'Make' command to build cordova website dont work in windows
gandhirajan commented on a change in pull request #804: CB-13964 - 'Make' command to build cordova website dont work in windows
URL: https://github.com/apache/cordova-docs/pull/804#discussion_r173949699
##########
File path: Makefile
##########
@@ -108,8 +108,8 @@ FETCH_SCRIPT = $(BIN_DIR)/fetch_docs.js
# which includes them on its own, and the SCSS compiler takes care of them;
# because of this, there is also no .scss -> .css pattern rule
ifdef WINDOWS
-SCSS_SRC = $(subst $(PWD)/,,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir *.scss /S /B)))
-STYLES_SRC = $(subst $(PWD)/,,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir *.less *.css /S /B)))
+SCSS_SRC = $(subst $(dir $(realpath $(firstword $(MAKEFILE_LIST)))),,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir *.scss /S /B)))
+STYLES_SRC = $(subst $(dir $(realpath $(firstword $(MAKEFILE_LIST)))),,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir *.less *.css /S /B)))
Review comment:
@dblotsky Thanks for the review comments Dmitry. Have added PWD variable to make it more readable. $(shell pwd) does not work for me seamlessly. pwd works for me only in powershell. So the above solution is seamless i feel. Let me know your thoughts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org