You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Lucene/Solr QA (Jira)" <ji...@apache.org> on 2019/10/25 05:17:00 UTC
[jira] [Commented] (SOLR-13870) eliminate getNextAvailablePort()
dependency in SolrJmxReporterTest
[ https://issues.apache.org/jira/browse/SOLR-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959439#comment-16959439 ]
Lucene/Solr QA commented on SOLR-13870:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 45m 46s{color} | {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 43s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.SystemCollectionCompatTest |
| | solr.cloud.TestTlogReplica |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13870 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12983958/SOLR-13870.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh |
| git revision | master / 3524494025d |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/588/artifact/out/patch-unit-solr_core.txt |
| Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/588/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/588/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> eliminate getNextAvailablePort() dependency in SolrJmxReporterTest
> ------------------------------------------------------------------
>
> Key: SOLR-13870
> URL: https://issues.apache.org/jira/browse/SOLR-13870
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-13870.patch
>
>
> {{SolrJmxReporterTest}} is currently the only solr test using (the problematic) {{SolrTestCaseJ4.getNextAvailablePort}} helper method in order to assign a RMI port for running a JMX server.
> This test doesn't actually care that it's using RMI for JMX, it only cares that:
> # an MBeanServer is initialized that it can query
> # that MBeanServer can be specified in the plugin configuration for the {{SolrJmxReporter}}
> We should cleanup the test initialization so that it no longer depends on RMI via the {{serviceUrl}} plugin configuration option, and instead just use the {{agentId}} to specify an MBeanServer bootstrapped by the test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org