You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/04/11 08:45:15 UTC
Re: Review Request 45200: Duplicate flags with keyword 'slave'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/
-----------------------------------------------------------
(Updated April 11, 2016, 6:45 a.m.)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Duplicate flags with keyword 'slave'.
Repository: mesos
Description (updated)
-------
It duplicates master/slave flags that contain 'slave'. This is
part of the epic replacing all keyword 'slave' with 'agent' in
current codebase.
Diffs (updated)
-----
CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3
src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa
src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842
src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631
src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644
src/tests/flags_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45200/diff/
Testing (updated)
-------
./configure --with-network-isolator
make check (on OSX and Ubuntu)
Thanks,
Jay Guo
Re: Review Request 45200: Duplicate flags with keyword 'slave'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review128089
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45200]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 11, 2016, 6:45 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 6:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It duplicates master/slave flags that contain 'slave'. This is
> part of the epic replacing all keyword 'slave' with 'agent' in
> current codebase.
>
>
> Diffs
> -----
>
> CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3
> src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa
> src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842
> src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
> src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631
> src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644
> src/tests/flags_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45200/diff/
>
>
> Testing
> -------
>
> ./configure --with-network-isolator
> make check (on OSX and Ubuntu)
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 45200: Duplicate flags with keyword 'slave'.
Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/
-----------------------------------------------------------
(Updated April 12, 2016, 4:50 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
@Jay, can you please attach bug ids to the reviews? I'll do it for this review for now -- @vinodkone
Bugs: MESOS-3781
https://issues.apache.org/jira/browse/MESOS-3781
Repository: mesos
Description
-------
It duplicates master/slave flags that contain 'slave'. This is
part of the epic replacing all keyword 'slave' with 'agent' in
current codebase.
Diffs
-----
CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3
src/Makefile.am dc8f8e31c5ea229e20c4f7e4d15db1ae756938aa
src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842
src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631
src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644
src/tests/flags_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45200/diff/
Testing
-------
./configure --with-network-isolator
make check (on OSX and Ubuntu)
Thanks,
Jay Guo