You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2023/08/03 11:19:04 UTC

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3355: FINERACT-1958-Configuration-down-payment

adamsaghy commented on code in PR #3355:
URL: https://github.com/apache/fineract/pull/3355#discussion_r1283053645


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java:
##########
@@ -210,6 +210,12 @@ public class LoanProduct extends AbstractPersistableCustom {
     @Column(name = "overdue_days_for_repayment_event")
     private Integer overDueDaysForRepaymentEvent;
 
+    @Column(name = "enable_down_payment", nullable = false)
+    private boolean enableDownPayment;
+
+    @Column(name = "disbursed_amount_percentage_down_payment", scale = 2, precision = 5)
+    private BigDecimal disbursedAmountPercentageDownPayment;

Review Comment:
   i am not too fond of this naming. Maybe disbursedAmountPercentage**For**DownPayment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org