You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "rmdmattingly (via GitHub)" <gi...@apache.org> on 2023/06/22 19:13:20 UTC
[GitHub] [hbase] rmdmattingly opened a new pull request, #5306: HBASE-27657: Connection and Request Attributes
rmdmattingly opened a new pull request, #5306:
URL: https://github.com/apache/hbase/pull/5306
Currently we have the ability to set Operation attributes, via Get.setAttribute, etc. It would be useful to be able to set attributes at the request and connection level.
These levels can result in less duplication. For example, send some attributes once per connection instead of for every one of the millions of requests a connection might send. Or send once for the request, instead of duplicating on every operation in a multi request.
Additionally, the Connection and RequestHeader are more globally available on the server side. Both can be accessed via RpcServer.getCurrentCall(), which is useful in various integration points ā coprocessors, custom queues, quotas, slow log, etc. Operation attributes are harder to access because you need to parse the raw Message into the appropriate type to get access to the getter.
This PR introduces two new avenues for providing attributes:
* passing in a map of connection attributes to `ConnectionFactory#createConnection`
* specifying a custom RPC controller which provides your request attributes
We've also added a test which tests both systems end-to-end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly closed pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly closed pull request #5306: HBASE-27657: Connection and Request Attributes
URL: https://github.com/apache/hbase/pull/5306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603244277
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 58s | master passed |
| +1 :green_heart: | compile | 4m 42s | master passed |
| +1 :green_heart: | checkstyle | 1m 32s | master passed |
| +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 42s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 26s | root in the patch failed. |
| -1 :x: | compile | 0m 28s | hbase-client in the patch failed. |
| -1 :x: | compile | 1m 15s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 18s | hbase-thrift in the patch failed. |
| -0 :warning: | cc | 0m 28s | hbase-client in the patch failed. |
| -0 :warning: | cc | 1m 15s | hbase-server in the patch failed. |
| -0 :warning: | cc | 0m 18s | hbase-thrift in the patch failed. |
| -0 :warning: | javac | 0m 28s | hbase-client in the patch failed. |
| -0 :warning: | javac | 1m 15s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 18s | hbase-thrift in the patch failed. |
| -0 :warning: | checkstyle | 0m 35s | hbase-server: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | hadoopcheck | 1m 44s | The patch causes 24 errors with Hadoop v3.2.4. |
| -1 :x: | hadoopcheck | 3m 33s | The patch causes 24 errors with Hadoop v3.3.5. |
| -1 :x: | hbaseprotoc | 0m 30s | hbase-server in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 21s | hbase-thrift in the patch failed. |
| +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. |
| -1 :x: | spotbugs | 1m 18s | hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | spotbugs | 0m 38s | hbase-server in the patch failed. |
| -1 :x: | spotbugs | 0m 22s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. |
| | | 37m 57s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-client |
| | There is an apparent infinite recursive loop in org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(Configuration, ExecutorService, User) At ConnectionFactory.java:recursive loop in org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(Configuration, ExecutorService, User) At ConnectionFactory.java:[line 220] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 025445acf66e 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-javac-3.3.5.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt |
| Max. process+thread count | 80 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603277454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 56s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 58s | master passed |
| +1 :green_heart: | compile | 2m 10s | master passed |
| +1 :green_heart: | shadedjars | 4m 50s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 37s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 36s | root in the patch failed. |
| -1 :x: | compile | 0m 49s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 22s | hbase-thrift in the patch failed. |
| -0 :warning: | javac | 0m 49s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 22s | hbase-thrift in the patch failed. |
| -1 :x: | shadedjars | 4m 15s | patch has 24 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 35s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 1m 6s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 47s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 52s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 0m 22s | hbase-thrift in the patch failed. |
| | | 27m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux fd942f7c4d28 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Temurin-1.8.0_352-b08 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/testReport/ |
| Max. process+thread count | 232 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608624736
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 41s | master passed |
| +1 :green_heart: | compile | 4m 43s | master passed |
| +1 :green_heart: | checkstyle | 1m 30s | master passed |
| +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 41s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 41s | the patch passed |
| +1 :green_heart: | compile | 4m 39s | the patch passed |
| +1 :green_heart: | cc | 4m 39s | the patch passed |
| +1 :green_heart: | javac | 4m 39s | the patch passed |
| -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 10m 10s | Patch does not cause any errors with Hadoop 3.2.4 3.3.5. |
| +1 :green_heart: | hbaseprotoc | 1m 44s | the patch passed |
| +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 6m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 51m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux f75343c156fa 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 81 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608428084
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 48s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 32s | master passed |
| +1 :green_heart: | compile | 2m 28s | master passed |
| +1 :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 37s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 56s | root in the patch failed. |
| -1 :x: | compile | 0m 19s | hbase-client in the patch failed. |
| -1 :x: | compile | 0m 30s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 18s | hbase-mapreduce in the patch failed. |
| -0 :warning: | javac | 0m 19s | hbase-client in the patch failed. |
| -0 :warning: | javac | 0m 30s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 18s | hbase-mapreduce in the patch failed. |
| -1 :x: | shadedjars | 2m 3s | patch has 17 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 37s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 20s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 34s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 16s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 5m 0s | hbase-thrift in the patch failed. |
| | | 27m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 52cfbf2a4a01 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 66fd6db9c5 |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/testReport/ |
| Max. process+thread count | 1174 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603276915
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 53s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 40s | master passed |
| +1 :green_heart: | compile | 2m 27s | master passed |
| +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 40s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 36s | root in the patch failed. |
| -1 :x: | compile | 0m 48s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 22s | hbase-thrift in the patch failed. |
| -0 :warning: | javac | 0m 48s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 22s | hbase-thrift in the patch failed. |
| -1 :x: | shadedjars | 3m 34s | patch has 24 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 38s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 1m 7s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 46s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 50s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 0m 22s | hbase-thrift in the patch failed. |
| | | 27m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f1e5b88802b7 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/testReport/ |
| Max. process+thread count | 256 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603356563
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 39s | master passed |
| +1 :green_heart: | compile | 4m 39s | master passed |
| +1 :green_heart: | checkstyle | 1m 32s | master passed |
| +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 40s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 42s | the patch passed |
| +1 :green_heart: | compile | 4m 40s | the patch passed |
| +1 :green_heart: | cc | 4m 40s | the patch passed |
| +1 :green_heart: | javac | 4m 40s | the patch passed |
| -0 :warning: | checkstyle | 0m 34s | hbase-server: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 10m 7s | Patch does not cause any errors with Hadoop 3.2.4 3.3.5. |
| +1 :green_heart: | hbaseprotoc | 1m 45s | the patch passed |
| +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 6m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 51m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 1bcd19fbc7c3 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 82 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1621815034
I've replied on the jira issue as I do not have the permission to comment on the design doc...
PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1610415668
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 53s | master passed |
| +1 :green_heart: | compile | 2m 17s | master passed |
| +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 27s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 46s | the patch passed |
| +1 :green_heart: | compile | 2m 17s | the patch passed |
| +1 :green_heart: | javac | 2m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 35s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 32s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 212m 36s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 12m 33s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 2s | hbase-thrift in the patch passed. |
| | | 261m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c7dd1488069f 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/testReport/ |
| Max. process+thread count | 4506 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on code in PR #5306:
URL: https://github.com/apache/hbase/pull/5306#discussion_r1239816341
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcControllerImpl.java:
##########
@@ -166,6 +167,11 @@ public boolean hasCallTimeout() {
return callTimeout != null;
}
+ @Override
+ public Map<String, byte[]> getAttributes() {
+ return null;
Review Comment:
Good point/question ā this is done in a sense because the default controller won't provide any request attributes. I could think about whether there's a way to make the interface simpler here, so that rather than needing to provide a custom controller a user could just set some RequestHeaderProvider in the Configuration that's then called here. But I think that might be a little tricky and would add some significant amount of code that still, in its default form, has nothing to provide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603287864
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 47s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 32s | master passed |
| +1 :green_heart: | compile | 4m 48s | master passed |
| +1 :green_heart: | checkstyle | 1m 38s | master passed |
| +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 53s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 32s | root in the patch failed. |
| -1 :x: | compile | 0m 29s | hbase-client in the patch failed. |
| -1 :x: | compile | 1m 16s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 20s | hbase-thrift in the patch failed. |
| -0 :warning: | cc | 0m 29s | hbase-client in the patch failed. |
| -0 :warning: | cc | 1m 16s | hbase-server in the patch failed. |
| -0 :warning: | cc | 0m 20s | hbase-thrift in the patch failed. |
| -0 :warning: | javac | 0m 29s | hbase-client in the patch failed. |
| -0 :warning: | javac | 1m 16s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 20s | hbase-thrift in the patch failed. |
| -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | hadoopcheck | 1m 41s | The patch causes 24 errors with Hadoop v3.2.4. |
| -1 :x: | hadoopcheck | 3m 30s | The patch causes 24 errors with Hadoop v3.3.5. |
| -1 :x: | hbaseprotoc | 0m 32s | hbase-server in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 19s | hbase-thrift in the patch failed. |
| +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. |
| -1 :x: | spotbugs | 0m 51s | hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | spotbugs | 0m 32s | hbase-server in the patch failed. |
| -1 :x: | spotbugs | 0m 21s | hbase-thrift in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 36m 18s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-client |
| | There is an apparent infinite recursive loop in org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(Configuration, ExecutorService, User) At ConnectionFactory.java:recursive loop in org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(Configuration, ExecutorService, User) At ConnectionFactory.java:[line 220] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux defb07fa421f 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-javac-3.2.4.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-javac-3.3.5.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt |
| Max. process+thread count | 81 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/2/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "bbeaudreault (via GitHub)" <gi...@apache.org>.
bbeaudreault commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1604672536
Since `RpcCall` interface is LimitedPrivate with exposure to COPROC, one could decide to inspect Connection or Request attributes in their coprocessor. For example, `RpcServer.getCurrentCall().get().getConnectionHeader().getAttributes()` (or `getHeader().getAttributes()` for Request attributes).
These could be used in various ways in coprocessors depending on the implementation. They also exist as a building block for other native features in the future, like Quota Groups that Ray mentioned. We also plan to expose them in SlowLog payload, so one could get valuable tracing information from their clients.
Sounds like Duo did not have an issue with the API defined here, so we could just encode this into a simple design doc with slightly more formal version of the above to describe how they could be used and why they are an improvement over Operation attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608858365
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 48s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 11s | master passed |
| +1 :green_heart: | compile | 2m 7s | master passed |
| +1 :green_heart: | shadedjars | 4m 33s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 24s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 13s | the patch passed |
| +1 :green_heart: | compile | 2m 8s | the patch passed |
| +1 :green_heart: | javac | 2m 8s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 32s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 57s | hbase-client in the patch failed. |
| -1 :x: | unit | 223m 52s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 14m 4s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 9s | hbase-thrift in the patch passed. |
| | | 271m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 76eae1677fb2 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Temurin-1.8.0_352-b08 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/testReport/ |
| Max. process+thread count | 4195 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608435912
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 0s | master passed |
| +1 :green_heart: | compile | 4m 41s | master passed |
| +1 :green_heart: | checkstyle | 1m 34s | master passed |
| +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 46s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 53s | root in the patch failed. |
| -1 :x: | compile | 0m 31s | hbase-client in the patch failed. |
| -1 :x: | compile | 0m 26s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | cc | 0m 31s | hbase-client in the patch failed. |
| -0 :warning: | cc | 0m 26s | hbase-server in the patch failed. |
| -0 :warning: | cc | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | javac | 0m 31s | hbase-client in the patch failed. |
| -0 :warning: | javac | 0m 26s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | hadoopcheck | 0m 55s | The patch causes 17 errors with Hadoop v3.2.4. |
| -1 :x: | hadoopcheck | 1m 52s | The patch causes 17 errors with Hadoop v3.3.5. |
| -1 :x: | hbaseprotoc | 0m 10s | hbase-client in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 27s | hbase-server in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 15s | hbase-mapreduce in the patch failed. |
| +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. |
| -1 :x: | spotbugs | 0m 11s | hbase-client in the patch failed. |
| -1 :x: | spotbugs | 0m 24s | hbase-server in the patch failed. |
| -1 :x: | spotbugs | 0m 13s | hbase-mapreduce in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. |
| | | 32m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 0cceed2d76a0 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 66fd6db9c5 |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-mapreduce.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-mapreduce.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-compile-hbase-mapreduce.txt |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-javac-3.2.4.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-javac-3.3.5.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-mapreduce.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-general-check/output/patch-spotbugs-hbase-mapreduce.txt |
| Max. process+thread count | 81 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1610053440
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 7s | master passed |
| +1 :green_heart: | compile | 3m 3s | master passed |
| +1 :green_heart: | shadedjars | 5m 56s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 45s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 25s | the patch passed |
| +1 :green_heart: | compile | 2m 41s | the patch passed |
| +1 :green_heart: | javac | 2m 41s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 41s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 40s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 39s | hbase-client in the patch passed. |
| -1 :x: | unit | 260m 2s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 13m 17s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 18s | hbase-thrift in the patch passed. |
| | | 314m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 07b1e332be6e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/testReport/ |
| Max. process+thread count | 4189 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1610425235
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 1s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 18s | master passed |
| +1 :green_heart: | compile | 2m 5s | master passed |
| +1 :green_heart: | shadedjars | 4m 30s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 23s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 16s | the patch passed |
| +1 :green_heart: | compile | 2m 8s | the patch passed |
| +1 :green_heart: | javac | 2m 8s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 29s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 14s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 31s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 14s | hbase-client in the patch passed. |
| -1 :x: | unit | 226m 1s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 14m 14s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 12s | hbase-thrift in the patch passed. |
| | | 276m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c48ba4a08ab5 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Temurin-1.8.0_352-b08 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/testReport/ |
| Max. process+thread count | 4180 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1610008614
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 50s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 13s | master passed |
| +1 :green_heart: | compile | 2m 5s | master passed |
| +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 21s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 15s | the patch passed |
| +1 :green_heart: | compile | 2m 6s | the patch passed |
| +1 :green_heart: | javac | 2m 7s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. |
| +1 :green_heart: | unit | 1m 17s | hbase-client in the patch passed. |
| -1 :x: | unit | 231m 52s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 13m 50s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 20s | hbase-thrift in the patch passed. |
| | | 279m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 8e20b62df079 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Temurin-1.8.0_352-b08 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/testReport/ |
| Max. process+thread count | 4387 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1632607193
After the aforementioned discussion, we're going to rethink the approach here a bit so I'm going to close this PR and reopen when we have a more straightforward/user-friendly implementation. Thanks for the feedback here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603232370
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 52s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 45s | master passed |
| +1 :green_heart: | compile | 2m 27s | master passed |
| +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 38s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 33s | root in the patch failed. |
| -1 :x: | compile | 0m 48s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 21s | hbase-thrift in the patch failed. |
| -0 :warning: | javac | 0m 48s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 21s | hbase-thrift in the patch failed. |
| -1 :x: | shadedjars | 3m 32s | patch has 24 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 39s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 1m 7s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 57s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 57s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 0m 20s | hbase-thrift in the patch failed. |
| | | 27m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux eba80fe821c0 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/testReport/ |
| Max. process+thread count | 261 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1610233475
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 47s | master passed |
| +1 :green_heart: | compile | 4m 39s | master passed |
| +1 :green_heart: | checkstyle | 1m 31s | master passed |
| +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 45s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 44s | the patch passed |
| +1 :green_heart: | compile | 4m 40s | the patch passed |
| +1 :green_heart: | cc | 4m 40s | the patch passed |
| +1 :green_heart: | javac | 4m 40s | the patch passed |
| -0 :warning: | checkstyle | 0m 34s | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 10m 17s | Patch does not cause any errors with Hadoop 3.2.4 3.3.5. |
| +1 :green_heart: | hbaseprotoc | 1m 46s | the patch passed |
| +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 6m 24s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 52m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux ab524a9e73fc 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608473500
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 43s | master passed |
| +1 :green_heart: | compile | 4m 39s | master passed |
| +1 :green_heart: | checkstyle | 1m 24s | master passed |
| +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 5m 45s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 48s | root in the patch failed. |
| -1 :x: | compile | 0m 29s | hbase-client in the patch failed. |
| -1 :x: | compile | 0m 26s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | cc | 0m 29s | hbase-client in the patch failed. |
| -0 :warning: | cc | 0m 26s | hbase-server in the patch failed. |
| -0 :warning: | cc | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | javac | 0m 29s | hbase-client in the patch failed. |
| -0 :warning: | javac | 0m 26s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | checkstyle | 0m 32s | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | hadoopcheck | 0m 55s | The patch causes 17 errors with Hadoop v3.2.4. |
| -1 :x: | hadoopcheck | 1m 50s | The patch causes 17 errors with Hadoop v3.3.5. |
| -1 :x: | hbaseprotoc | 0m 10s | hbase-client in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 27s | hbase-server in the patch failed. |
| -1 :x: | hbaseprotoc | 0m 15s | hbase-mapreduce in the patch failed. |
| +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. |
| -1 :x: | spotbugs | 0m 10s | hbase-client in the patch failed. |
| -1 :x: | spotbugs | 0m 23s | hbase-server in the patch failed. |
| -1 :x: | spotbugs | 0m 14s | hbase-mapreduce in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 31m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux ec8b2c9b690d 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 66fd6db9c5 |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-mapreduce.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-mapreduce.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-compile-hbase-mapreduce.txt |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-javac-3.2.4.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-javac-3.3.5.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt |
| hbaseprotoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-mapreduce.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt |
| spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-mapreduce.txt |
| Max. process+thread count | 80 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #5306:
URL: https://github.com/apache/hbase/pull/5306#discussion_r1239225855
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcControllerImpl.java:
##########
@@ -166,6 +167,11 @@ public boolean hasCallTimeout() {
return callTimeout != null;
}
+ @Override
+ public Map<String, byte[]> getAttributes() {
+ return null;
Review Comment:
This is not done yet?
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:
##########
@@ -216,21 +217,53 @@ public static Connection createConnection(Configuration conf, User user) throws
*/
public static Connection createConnection(Configuration conf, ExecutorService pool,
final User user) throws IOException {
+ return createConnection(conf, pool, user, null);
Review Comment:
Better just use Collections.emptyMap here, so we do not need a null check in later code, usually.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java:
##########
@@ -17,6 +17,8 @@
*/
package org.apache.hadoop.hbase.ipc;
+import static org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos.*;
Review Comment:
Avoid star imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1621821227
Thank you for taking a look! Iām on vacation this week so I will think about the feedback and get back to you early next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608469787
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 49s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 12s | master passed |
| +1 :green_heart: | compile | 2m 8s | master passed |
| +1 :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 28s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 0s | root in the patch failed. |
| -1 :x: | compile | 0m 19s | hbase-client in the patch failed. |
| -1 :x: | compile | 0m 31s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 22s | hbase-mapreduce in the patch failed. |
| -0 :warning: | javac | 0m 19s | hbase-client in the patch failed. |
| -0 :warning: | javac | 0m 31s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 22s | hbase-mapreduce in the patch failed. |
| -1 :x: | shadedjars | 2m 42s | patch has 17 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 35s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 18s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 30s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 20s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 5m 4s | hbase-thrift in the patch failed. |
| | | 28m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 1b32709af7ef 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 66fd6db9c5 |
| Default Java | Temurin-1.8.0_352-b08 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/testReport/ |
| Max. process+thread count | 1125 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608862660
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 46s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 45s | master passed |
| +1 :green_heart: | compile | 2m 27s | master passed |
| +1 :green_heart: | shadedjars | 4m 40s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 38s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 33s | the patch passed |
| +1 :green_heart: | compile | 2m 28s | the patch passed |
| +1 :green_heart: | javac | 2m 28s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 39s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 1m 6s | hbase-client in the patch failed. |
| -1 :x: | unit | 225m 33s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 14m 10s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 18s | hbase-thrift in the patch passed. |
| | | 276m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 32fe57fe8c0c 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/testReport/ |
| Max. process+thread count | 4467 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/6/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603502238
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 2s | master passed |
| +1 :green_heart: | compile | 2m 18s | master passed |
| +1 :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 28s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 45s | the patch passed |
| +1 :green_heart: | compile | 2m 14s | the patch passed |
| +1 :green_heart: | javac | 2m 14s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 1m 12s | hbase-client in the patch failed. |
| -1 :x: | unit | 212m 36s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 12m 42s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 1s | hbase-thrift in the patch passed. |
| | | 261m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 9b146b85f6c3 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/testReport/ |
| Max. process+thread count | 4507 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1604304762
> My concern here is how our users could make use of this feature. Users can send customized connection headers or request headers at client side, but how do they plan to make use of these attributes at server side?
Good question. Right now there isn't much out-of-the-box that one will get server-side via these attributes. One could trivially begin using these attributes in their coprocessor(s), for example.
Medium/long term, we also have plans to use these attributes at my day job by implementing a new type of quota. At my company we run thousands of microservices, some of which are very fundamental and consequently have a variety of "upstream callers". These proxy APIs, from HBase's perspective, are a single user and can only be throttled as such ā but we may have some single pathologic upstream caller that ideally could be throttled in isolation. Another common, similar, problem we see is MapReduce jobs accidentally creating hotspots. Our solution is to support custom quota groupings ([HBASE-27784](https://issues.apache.org/jira/browse/HBASE-27784)) which could be powered by, for example, request attributes. From the issue:
> Basically when a Connection is established we can set an attribute (i.e. quotaGrouping=hadoop or quotaGrouping=MyProxyAPI). In QuotaCache, we can add a getQuotaGroupLimiter(String groupName) and also allow someone to define quotas using set_quota TYPE => THROTTLE, GROUP => 'hadoop', LIMIT => '100M/sec'
Also š on the design doc / hbase-examples. If we have agreement on the vague shape of things here then I'll definitely go ahead on building out examples!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1609639831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 55s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 18s | master passed |
| +1 :green_heart: | compile | 5m 32s | master passed |
| +1 :green_heart: | checkstyle | 1m 38s | master passed |
| +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 6m 3s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 35s | the patch passed |
| +1 :green_heart: | compile | 5m 36s | the patch passed |
| +1 :green_heart: | cc | 5m 36s | the patch passed |
| +1 :green_heart: | javac | 5m 36s | the patch passed |
| -0 :warning: | checkstyle | 0m 39s | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 10m 44s | Patch does not cause any errors with Hadoop 3.2.4 3.3.5. |
| +1 :green_heart: | hbaseprotoc | 1m 53s | the patch passed |
| +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 6m 33s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. |
| | | 56m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 4dd251962e86 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0637bbc74b |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 81 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/7/console |
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608426683
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 48s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 16s | master passed |
| +1 :green_heart: | compile | 2m 4s | master passed |
| +1 :green_heart: | shadedjars | 4m 34s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 25s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 45s | root in the patch failed. |
| -1 :x: | compile | 0m 18s | hbase-client in the patch failed. |
| -1 :x: | compile | 0m 27s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 17s | hbase-mapreduce in the patch failed. |
| -0 :warning: | javac | 0m 18s | hbase-client in the patch failed. |
| -0 :warning: | javac | 0m 27s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 17s | hbase-mapreduce in the patch failed. |
| -1 :x: | shadedjars | 2m 0s | patch has 17 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 29s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 20s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 27s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 17s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 4m 59s | hbase-thrift in the patch failed. |
| | | 25m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 055cc8feec5c 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 66fd6db9c5 |
| Default Java | Temurin-1.8.0_352-b08 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/testReport/ |
| Max. process+thread count | 1123 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/4/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608468634
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 47s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 33s | master passed |
| +1 :green_heart: | compile | 2m 29s | master passed |
| +1 :green_heart: | shadedjars | 4m 33s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 34s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 53s | root in the patch failed. |
| -1 :x: | compile | 0m 19s | hbase-client in the patch failed. |
| -1 :x: | compile | 0m 30s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 19s | hbase-mapreduce in the patch failed. |
| -0 :warning: | javac | 0m 19s | hbase-client in the patch failed. |
| -0 :warning: | javac | 0m 30s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 19s | hbase-mapreduce in the patch failed. |
| -1 :x: | shadedjars | 2m 3s | patch has 17 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 38s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 20s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 31s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 18s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 4m 57s | hbase-thrift in the patch failed. |
| | | 27m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d88a23f16220 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 66fd6db9c5 |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-mapreduce.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/testReport/ |
| Max. process+thread count | 1174 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/5/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1608199598
[Here's an initial design doc draft](https://docs.google.com/document/d/1cGEmUn2kAPhn_Q18DvAOhigtCbnQ8ia6oV4OvMb5DyU/edit?usp=sharing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603228614
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 44s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 27s | master passed |
| +1 :green_heart: | compile | 2m 8s | master passed |
| +1 :green_heart: | shadedjars | 4m 29s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 24s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 14s | root in the patch failed. |
| -1 :x: | compile | 0m 39s | hbase-server in the patch failed. |
| -1 :x: | compile | 0m 20s | hbase-thrift in the patch failed. |
| -0 :warning: | javac | 0m 39s | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 20s | hbase-thrift in the patch failed. |
| -1 :x: | shadedjars | 3m 23s | patch has 24 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 31s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 56s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 38s | hbase-server in the patch failed. |
| -1 :x: | unit | 0m 42s | hbase-mapreduce in the patch failed. |
| -1 :x: | unit | 0m 20s | hbase-thrift in the patch failed. |
| | | 24m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 020be69d51df 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Temurin-1.8.0_352-b08 |
| mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/testReport/ |
| Max. process+thread count | 228 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/1/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1603507376
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 47s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 25s | master passed |
| +1 :green_heart: | compile | 2m 6s | master passed |
| +1 :green_heart: | shadedjars | 4m 29s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 24s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 16s | the patch passed |
| +1 :green_heart: | compile | 2m 5s | the patch passed |
| +1 :green_heart: | javac | 2m 5s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 30s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. |
| -1 :x: | unit | 0m 57s | hbase-client in the patch failed. |
| -1 :x: | unit | 223m 31s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 14m 14s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 5m 10s | hbase-thrift in the patch passed. |
| | | 271m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/5306 |
| JIRA Issue | HBASE-27657 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux a939df583a8e 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / da171c341e |
| Default Java | Temurin-1.8.0_352-b08 |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/testReport/ |
| Max. process+thread count | 4190 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-mapreduce hbase-thrift U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/3/console |
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1629651250
For posterity, we've continued the conversation here: https://issues.apache.org/jira/browse/HBASE-27657?focusedCommentId=17741604&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17741604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5306: HBASE-27657: Connection and Request Attributes
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #5306:
URL: https://github.com/apache/hbase/pull/5306#issuecomment-1611299203
I think [this test failure](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5306/8/testReport/) is unrelated/noise. Can we re-run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org