You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by zhangkaizhao <gi...@git.apache.org> on 2016/02/01 20:55:52 UTC
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
GitHub user zhangkaizhao opened a pull request:
https://github.com/apache/cordova-docs/pull/477
Execute jekyll in the context of the bundle
Execute jekyll in the context of the bundle because jekyll is installed by bundle here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangkaizhao/cordova-docs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #477
----
commit fd46c712fbe02b704cbe3bfd12ab3ce4cb26d8c6
Author: zhangkaizhao <zh...@gmail.com>
Date: 2016-02-01T19:52:33Z
Execute jekyll in the context of the bundle because jekyll is installed by bundle here
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-178520326
This is a great feature that I had no idea about. Thank you, @zhangkaizhao, for contributing this piece of Ruby/Bundle knowledge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-178520738
@zhangkaizhao before we merge, please also add this to the Makefile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-179644356
@zhangkaizhao thanks for your contribution! If you are interested in contributing more to Cordova or other Apache projects, I recommend for you to sign the [Apache ICLA][icla]. In this case it didn't matter because this repo is not distributed, but for other repositories it might be required.
All the best!
[icla]: http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...
Posted by zhangkaizhao <gi...@git.apache.org>.
Github user zhangkaizhao commented on the pull request:
https://github.com/apache/cordova-docs/pull/477#issuecomment-179662355
@dblotsky OK! Thanks for you suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org