[jira] [Commented] (ZOOKEEPER-2019) Unhandled exception when setting invalid limits data in /zookeeper/quota/some/path/zookeeper_limits

["Hongchao Deng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145680#comment-14145680 ] 

Hongchao Deng commented on ZOOKEEPER-2019:
------------------------------------------

Also created a RB: https://reviews.apache.org/r/25968/

> Unhandled exception when setting invalid limits data in /zookeeper/quota/some/path/zookeeper_limits 
> ----------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2019
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2019
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.1
>
>         Attachments: ZOOKEEPER-2019-v2.patch, ZOOKEEPER-2019-ver1.patch, ZOOKEEPER-2019.patch, ZOOKEEPER-2019.patch
>
>
> If you have quotas properly set for a given path, i.e.:
> {noformat}
> create /zookeeper/quota/test/zookeeper_limits 'count=1,bytes=100'
> create /zookeeper/quota/test/zookeeper_stats 'count=1,bytes=100'
> {noformat}
> and then you update the limits znode with bogus data, i.e.:
> {noformat}
> set /zookeeper/quota/test/zookeeper_limits ''
> {noformat}
> you'll crash the cluster because IllegalArgumentException isn't handled when dealing with quotas znodes:
> https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L379
> https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L425
> We should handle IllegalArgumentException. Optionally, we should also throw BadArgumentsException from PrepRequestProcessor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)