You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/04 02:19:30 UTC

[GitHub] [shardingsphere] lovepoem opened a new issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

lovepoem opened a new issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694


   Can anyone help to submit an IDEA version checkstyle.xml ?  It seems that the latest version of IDEA only supports importing idea format checkstyle
   
   
   ![image](https://user-images.githubusercontent.com/827112/95005421-e678c680-062a-11eb-986a-fa8320c84374.png)
   
   You can just export it here
   
   ![image](https://user-images.githubusercontent.com/827112/95005426-07d9b280-062b-11eb-88de-d1717b4bde82.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] kimmking commented on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-706003689


   @lovepoem  that's great, but I still suggest  DON'T Format project codes anytime and anywhere.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu edited a comment on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-703248056


   I export my setting, please see:
   
   ```xml
   <code_scheme name="ShardingSphere_Code_Style" version="173">
     <option name="LINE_SEPARATOR" value="&#xA;" />
     <option name="GENERATE_FINAL_LOCALS" value="true" />
     <option name="GENERATE_FINAL_PARAMETERS" value="true" />
     <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
     <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
     <JavaCodeStyleSettings>
       <option name="GENERATE_FINAL_LOCALS" value="true" />
       <option name="GENERATE_FINAL_PARAMETERS" value="true" />
       <option name="INSERT_INNER_CLASS_IMPORTS" value="true" />
       <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
       <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
       <option name="JD_ALIGN_PARAM_COMMENTS" value="false" />
       <option name="JD_ALIGN_EXCEPTION_COMMENTS" value="false" />
     </JavaCodeStyleSettings>
     <XML>
       <option name="XML_LEGACY_SETTINGS_IMPORTED" value="true" />
     </XML>
     <codeStyleSettings language="JAVA">
       <option name="KEEP_LINE_BREAKS" value="false" />
       <option name="KEEP_FIRST_COLUMN_COMMENT" value="false" />
       <option name="KEEP_CONTROL_STATEMENT_IN_ONE_LINE" value="false" />
       <option name="KEEP_MULTIPLE_EXPRESSIONS_IN_ONE_LINE" value="true" />
       <indentOptions>
         <option name="KEEP_INDENTS_ON_EMPTY_LINES" value="true" />
       </indentOptions>
       <arrangement>
         <groups>
           <group>
             <type>GETTERS_AND_SETTERS</type>
             <order>KEEP</order>
           </group>
           <group>
             <type>OVERRIDDEN_METHODS</type>
             <order>KEEP</order>
           </group>
           <group>
             <type>DEPENDENT_METHODS</type>
             <order>BREADTH_FIRST</order>
           </group>
         </groups>
       </arrangement>
     </codeStyleSettings>
   </code_scheme>
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] kimmking commented on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-706003689


   @lovepoem  that's great, but I still suggest  DON'T Format project codes anytime and anywhere.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] lovepoem closed issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
lovepoem closed issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-703248056


   I export my setting, please see.
   [Uploading ShardingSphere_Code_Style.xml…]()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu edited a comment on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-703248056


   I export my setting, please see:
   
   ```xml
   <code_scheme name="ShardingSphere_Code_Style" version="173">
     <option name="LINE_SEPARATOR" value="&#xA;" />
     <option name="GENERATE_FINAL_LOCALS" value="true" />
     <option name="GENERATE_FINAL_PARAMETERS" value="true" />
     <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
     <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
     <JavaCodeStyleSettings>
       <option name="GENERATE_FINAL_LOCALS" value="true" />
       <option name="GENERATE_FINAL_PARAMETERS" value="true" />
       <option name="INSERT_INNER_CLASS_IMPORTS" value="true" />
       <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
       <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
       <option name="JD_ALIGN_PARAM_COMMENTS" value="false" />
       <option name="JD_ALIGN_EXCEPTION_COMMENTS" value="false" />
     </JavaCodeStyleSettings>
     <XML>
       <option name="XML_LEGACY_SETTINGS_IMPORTED" value="true" />
     </XML>
     <codeStyleSettings language="JAVA">
       <option name="KEEP_LINE_BREAKS" value="false" />
       <option name="KEEP_FIRST_COLUMN_COMMENT" value="false" />
       <option name="KEEP_CONTROL_STATEMENT_IN_ONE_LINE" value="false" />
       <option name="KEEP_MULTIPLE_EXPRESSIONS_IN_ONE_LINE" value="true" />
       <indentOptions>
         <option name="KEEP_INDENTS_ON_EMPTY_LINES" value="true" />
       </indentOptions>
       <arrangement>
         <groups>
           <group>
             <type>GETTERS_AND_SETTERS</type>
             <order>KEEP</order>
           </group>
           <group>
             <type>OVERRIDDEN_METHODS</type>
             <order>KEEP</order>
           </group>
           <group>
             <type>DEPENDENT_METHODS</type>
             <order>BREADTH_FIRST</order>
           </group>
         </groups>
       </arrangement>
     </codeStyleSettings>
   </code_scheme>
   ```
   We need to talk about how to optimize the code style and make it as a standard rule.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] lovepoem commented on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
lovepoem commented on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-705490960


   It works well, I will pr this file


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] lovepoem commented on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
lovepoem commented on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-705490960


   It works well, I will pr this file


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] lovepoem commented on issue #7694: Can anyone help to submit an IDEA version checkstyle.xml ?

Posted by GitBox <gi...@apache.org>.
lovepoem commented on issue #7694:
URL: https://github.com/apache/shardingsphere/issues/7694#issuecomment-706490317


   Closed via https://github.com/apache/shardingsphere/pull/7711


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org