You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/23 00:52:23 UTC

[kudu-CR] cfile set-test: switch to using INT32 instead of UINT32 

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5194

Change subject: cfile_set-test: switch to using INT32 instead of UINT32
......................................................................

cfile_set-test: switch to using INT32 instead of UINT32

We don't actually support users using UINT32 anymore, so it's better to
test the exposed INT32 type.

Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
---
M src/kudu/tablet/cfile_set-test.cc
1 file changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/5194/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] cfile set-test: switch to using INT32 instead of UINT32

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: cfile_set-test: switch to using INT32 instead of UINT32
......................................................................


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] cfile set-test: switch to using INT32 instead of UINT32

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5194

to look at the new patch set (#4).

Change subject: cfile_set-test: switch to using INT32 instead of UINT32
......................................................................

cfile_set-test: switch to using INT32 instead of UINT32

We don't actually support users using UINT32 anymore, so it's better to
test the exposed INT32 type.

Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
---
M src/kudu/tablet/cfile_set-test.cc
1 file changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/5194/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] cfile set-test: switch to using INT32 instead of UINT32

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: cfile_set-test: switch to using INT32 instead of UINT32
......................................................................


cfile_set-test: switch to using INT32 instead of UINT32

We don't actually support users using UINT32 anymore, so it's better to
test the exposed INT32 type.

Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
Reviewed-on: http://gerrit.cloudera.org:8080/5194
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/cfile_set-test.cc
1 file changed, 20 insertions(+), 20 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48dd5e81c1cd725328ea96b030279d59a1c845a5
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>