You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/12 15:06:50 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #6826: Cdnjs integrity hashes

ocket8888 opened a new pull request, #6826:
URL: https://github.com/apache/trafficcontrol/pull/6826

   This PR adds integrity hashes to resources loaded from CDNs by the `test/router` TR load tests. It also sets their `crossorigin` behavior to `anonymous`. This shouldn't really matter because they're just tests, but it's exceedingly easy to do.
   
   This PR also eliminates some prototype pollution I found in the load-test script.
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - unknown
   
   ## What is the best way to verify this PR?
   You could run the TR load tests. I don't know how. For the integrity hashes, it should suffice to just load `index.html` into a browser and verify that the scripts load - if they don't it means the hashes are wrong.
   
   ## PR submission checklist
   - [x] This PR has tests 
   - [ ] This PR has documentation
   - [ ] This PR has a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] rawlinp merged pull request #6826: Cdnjs integrity hashes

Posted by GitBox <gi...@apache.org>.
rawlinp merged PR #6826:
URL: https://github.com/apache/trafficcontrol/pull/6826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org