You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2026/06/03 10:56:35 UTC
(tomcat) branch 9.0.x updated: Undo readability change that created infinite loop. Add comment instead.
This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new da1f54a030 Undo readability change that created infinite loop. Add comment instead.
da1f54a030 is described below
commit da1f54a03071dc5553983751b2f152c22682f025
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Jun 3 11:55:40 2026 +0100
Undo readability change that created infinite loop. Add comment instead.
---
.../net/openssl/ciphers/OpenSSLCipherConfigurationParser.java | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java b/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java
index 0df4c298bd..9280ba9485 100644
--- a/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java
+++ b/java/org/apache/tomcat/util/net/openssl/ciphers/OpenSSLCipherConfigurationParser.java
@@ -493,6 +493,13 @@ public class OpenSSLCipherConfigurationParser {
addListAlias(aSRP, filterByAuthentication(allCiphers, Collections.singleton(Authentication.SRP)));
addListAlias(kSRP, filterByKeyExchange(allCiphers, Collections.singleton(KeyExchange.SRP)));
addListAlias(SRP, filterByKeyExchange(allCiphers, Collections.singleton(KeyExchange.SRP)));
+
+ /*
+ * initialized needs to be set to true here to avoid an infinite loop as parse(String) will call init() if
+ * initialized is not true.
+ */
+ initialized = true;
+
addListAlias(DEFAULT, parse("ALL:!eNULL:!aNULL:!DES:!RC2:!RC4:!DSS:!SEED:!IDEA:!CAMELLIA:!AESCCM:!3DES:!ARIA"));
// COMPLEMENTOFDEFAULT is also not exactly as defined by the docs
LinkedHashSet<Cipher> complementOfDefault =
@@ -511,8 +518,6 @@ public class OpenSSLCipherConfigurationParser {
complementOfDefault.addAll(aliases.get(ARIA));
defaultSort(complementOfDefault);
addListAlias(COMPLEMENTOFDEFAULT, complementOfDefault);
-
- initialized = true;
}
static void addListAlias(String alias, Set<Cipher> ciphers) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org