[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

["Arun Patidar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309313#comment-15309313 ] 

Arun Patidar commented on OFBIZ-7147:
-------------------------------------

Hi [~pfm.smits],

Here, my suggestion is to fix the data only, as hasParentType() working as expected. There should be empty parentTypeId field for invoiceTypeId="SALES_INVOICE" and  invoiceTypeId="PURCHASE_INVOICE".

Please let me know if you have any other solution or concern.

> Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7147
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7147
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Arun Patidar
>            Assignee: Arun Patidar
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 
> Please refer AccountingTypeData.xml.
> <InvoiceType description="Purchase Invoice" hasTable="N" invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
> <InvoiceType description="Sales Invoice" hasTable="N" invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)