You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2016/01/15 22:48:26 UTC
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/457
CB-10367 Add meaningful names to heading anchors in Docs & show a link on hover
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs anchorLinks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #457
----
commit 9820ad9bd8ede317de6c53b9a1e94a566e2dd3de
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-01-15T21:46:12Z
CB-10367 Add meaningful names to heading anchors in Docs & show a link icon on hover
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/457#issuecomment-172105070
@dblotsky to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/457#issuecomment-173002762
Just a suggestion: maybe add some CSS to make the link vanish unless the title is hovered, and add a bit of spacing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/457#discussion_r50165370
--- Diff: www/static/js/docs.js ---
@@ -48,7 +57,10 @@ $(document).ready(function () {
// add a special class to the anchor for this toc entry
var anchorName = getAnchorName(i, heading, prefix);
$('#' + anchorName).addClass('fragment-anchor');
-
+ if (i > 0) {
+ // the first link is the header of the page - exclude it
--- End diff --
Nitpick: please put the comment above the `if`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/457#discussion_r50170623
--- Diff: _config.yml ---
@@ -73,7 +73,9 @@ redcarpet:
- lax_spacing
- tables
-
+
+ # enables anhor links
+ - with_toc_data
--- End diff --
Nitpick: please add a space under the option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/457#discussion_r50170880
--- Diff: www/static/js/docs.js ---
@@ -48,7 +57,10 @@ $(document).ready(function () {
// add a special class to the anchor for this toc entry
var anchorName = getAnchorName(i, heading, prefix);
$('#' + anchorName).addClass('fragment-anchor');
-
+ if (i > 0) {
--- End diff --
Should we also apply this condition to the above adding of `'fragment-anchor'`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/457#issuecomment-173042779
Thanks, Dmitry! I fixed the points that you brought up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org