You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2006/11/04 15:17:16 UTC

[jira] Created: (DERBY-2046) Make class org.apache.derby.iapi.store.raw.PageKey final

Make class org.apache.derby.iapi.store.raw.PageKey final
--------------------------------------------------------

                 Key: DERBY-2046
                 URL: http://issues.apache.org/jira/browse/DERBY-2046
             Project: Derby
          Issue Type: Improvement
          Components: Performance, Services
    Affects Versions: 10.3.0.0
            Reporter: Knut Anders Hatlen
         Assigned To: Knut Anders Hatlen
            Priority: Minor


The methods of the PageKey class are called frequently both from the lock manager and the cache manager. Since no other classes extend it, it should be declared final to help the run-time compiler optimize the method calls.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-2046) Make class org.apache.derby.iapi.store.raw.PageKey final

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-2046?page=all ]

Knut Anders Hatlen updated DERBY-2046:
--------------------------------------

    Attachment: pagekey.diff

This patch makes the class final. I have run a couple of performance tests with the test client in DERBY-1961. The effect of the patch is minimal, but it seems to have a small positive impact especially on the 10000x1000 joins.

> Make class org.apache.derby.iapi.store.raw.PageKey final
> --------------------------------------------------------
>
>                 Key: DERBY-2046
>                 URL: http://issues.apache.org/jira/browse/DERBY-2046
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services, Performance
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: pagekey.diff
>
>
> The methods of the PageKey class are called frequently both from the lock manager and the cache manager. Since no other classes extend it, it should be declared final to help the run-time compiler optimize the method calls.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DERBY-2046) Make class org.apache.derby.iapi.store.raw.PageKey final

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-2046?page=all ]

Knut Anders Hatlen closed DERBY-2046.
-------------------------------------

    Fix Version/s: 10.3.0.0
       Resolution: Fixed
       Derby Info:   (was: [Patch Available])

Committed revision 471862.

> Make class org.apache.derby.iapi.store.raw.PageKey final
> --------------------------------------------------------
>
>                 Key: DERBY-2046
>                 URL: http://issues.apache.org/jira/browse/DERBY-2046
>             Project: Derby
>          Issue Type: Improvement
>          Components: Performance, Services
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: pagekey.diff
>
>
> The methods of the PageKey class are called frequently both from the lock manager and the cache manager. Since no other classes extend it, it should be declared final to help the run-time compiler optimize the method calls.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DERBY-2046) Make class org.apache.derby.iapi.store.raw.PageKey final

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-2046:
---------------------------------

    Derby Categories: [Performance]

> Make class org.apache.derby.iapi.store.raw.PageKey final
> --------------------------------------------------------
>
>                 Key: DERBY-2046
>                 URL: https://issues.apache.org/jira/browse/DERBY-2046
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.3.1.4
>
>         Attachments: pagekey.diff
>
>
> The methods of the PageKey class are called frequently both from the lock manager and the cache manager. Since no other classes extend it, it should be declared final to help the run-time compiler optimize the method calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.