You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 00:05:24 UTC
[GitHub] [incubator-nuttx] hartmannathan opened a new issue #698:
tools/testbuild.sh breaks non-git usage
hartmannathan opened a new issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698
Regarding commit [27142b2e3c4c6498dc198818ec9b260d8ffff12f](https://github.com/apache/incubator-nuttx/commit/27142b2e3c4c6498dc198818ec9b260d8ffff12f), this means
that tools/testbuild.sh now depends on git and on the NuttX
distribution being a git clone.
The problem with depending on git is that users who work with release
tarballs and/or don't have git can no longer use NuttX.
We should not clean with git unless doing so in a git clone. If not a git clone, we should invoke 'make distclean' as we were doing previously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] hartmannathan commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608183933
> Being that it is testbuild script I think that's less of an issue but this looks to me like it should fallback to make distclean if it cannot use git. Have you verified that that is not the case?
Yes. The logic to run 'make distclean' is removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] hartmannathan commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608205843
> > > Being that it is testbuild script I think that's less of an issue but this looks to me like it should fallback to make distclean if it cannot use git. Have you verified that that is not the case?
> >
> >
> > Yes. The logic to run 'make distclean' is removed.
>
> It was left. There is an OR issued now so if the git fails I would expect make distclean to run.
You're right, I stand corrected. Somehow I missed it before but now it looks obvious.
I think PR 701 is a good idea anyway, because of Greg's concern (in the mail thread I linked previously) that the git clean invocation would delete other non-versioned data which the user might want to keep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] hartmannathan commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608184905
Also per the mailing list discussion ([here](https://lists.apache.org/thread.html/r6ef57ae749f59d8013c789256df334a0f47945d1826ad95998ebfa43%40%3Cdev.nuttx.apache.org%3E)), this git clean invocation will remove other untracked files which the user may want to keep. I understand that it's a testbuild script but somewhere down the line someone will run it for whatever reason and it can cause a big problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608189587
> > Being that it is testbuild script I think that's less of an issue but this looks to me like it should fallback to make distclean if it cannot use git. Have you verified that that is not the case?
>
> Yes. The logic to run 'make distclean' is removed.
It was left. There is an OR issued now so if the git fails I would expect make distclean to run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608209387
I agree, just wanted to make sure we had not missed something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #698: tools/testbuild.sh
breaks non-git usage
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608197800
* as @btashton btashton said, the fallback logic is still there. didn't it work for you?
* i submitted a patch to make the use of "git clean" optional. https://github.com/apache/incubator-nuttx/pull/701
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608188978
Maybe we can make a flag for that as an extra layer of protection, but the issue you opened is that this breaks non-git environments which does not look right to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #698:
tools/testbuild.sh breaks non-git usage
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #698: tools/testbuild.sh breaks non-git usage
URL: https://github.com/apache/incubator-nuttx/issues/698#issuecomment-608175151
Being that it is testbuild script I think that's less of an issue but this looks to me like it should fallback to make distclean if it cannot use git. Have you verified that that is not the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services