You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 10:07:08 UTC
[GitHub] [flink] JingsongLi opened a new pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem source to new table source sink interface
JingsongLi opened a new pull request #13767:
URL: https://github.com/apache/flink/pull/13767
## What is the purpose of the change
Migrate Filesystem source to new table source sink interface
## Brief change log
- Modify `FileSystemTableFactory`
- Introduce `AbstractFileSystemTable` for some common fields
- Modify `FileSystemTableSource`
- Modify `FileSystemTableSink`
## Verifying this change
This change is already covered by existing tests, such as `FileSystemITCaseBase`.
Need Factory testing for option validation.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
}, {
"hash" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282",
"triggerID" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"triggerType" : "PUSH"
}, {
"hash" : "bf0d914e9559cdfb49695af72933911fa83bbb26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bf0d914e9559cdfb49695af72933911fa83bbb26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* afd866cd911131de15dfe3a2d3ec80b93ea78da7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282)
* bf0d914e9559cdfb49695af72933911fa83bbb26 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
}, {
"hash" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282",
"triggerID" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 2979dcd1fa92a3a5653914203311aba30f62ad09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271)
* afd866cd911131de15dfe3a2d3ec80b93ea78da7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
}, {
"hash" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282",
"triggerID" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* afd866cd911131de15dfe3a2d3ec80b93ea78da7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218)
* 0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260)
* 2979dcd1fa92a3a5653914203311aba30f62ad09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 7e5bf1cc81043553e2f6df80a6b6412634c80609 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
}, {
"hash" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260)
* 2979dcd1fa92a3a5653914203311aba30f62ad09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271)
* afd866cd911131de15dfe3a2d3ec80b93ea78da7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #13767:
URL: https://github.com/apache/flink/pull/13767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 7e5bf1cc81043553e2f6df80a6b6412634c80609 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176)
* c532d886b68b7dd265c9056945a3cfc94e8352b7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
}, {
"hash" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282",
"triggerID" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"triggerType" : "PUSH"
}, {
"hash" : "bf0d914e9559cdfb49695af72933911fa83bbb26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8339",
"triggerID" : "bf0d914e9559cdfb49695af72933911fa83bbb26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* afd866cd911131de15dfe3a2d3ec80b93ea78da7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282)
* bf0d914e9559cdfb49695af72933911fa83bbb26 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8339)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 7e5bf1cc81043553e2f6df80a6b6412634c80609 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218)
* 0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260)
* 2979dcd1fa92a3a5653914203311aba30f62ad09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
}, {
"hash" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271",
"triggerID" : "2979dcd1fa92a3a5653914203311aba30f62ad09",
"triggerType" : "PUSH"
}, {
"hash" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282",
"triggerID" : "afd866cd911131de15dfe3a2d3ec80b93ea78da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260)
* 2979dcd1fa92a3a5653914203311aba30f62ad09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8271)
* afd866cd911131de15dfe3a2d3ec80b93ea78da7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* 7e5bf1cc81043553e2f6df80a6b6412634c80609 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176)
* c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #13767:
URL: https://github.com/apache/flink/pull/13767#discussion_r512012227
##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/filesystem/FileSystemTableFactoryTest.java
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.filesystem;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+import org.apache.flink.table.catalog.ObjectIdentifier;
+import org.apache.flink.table.connector.sink.DynamicTableSink;
+import org.apache.flink.table.connector.source.DynamicTableSource;
+import org.apache.flink.table.descriptors.DescriptorProperties;
+import org.apache.flink.table.factories.DataGenTableSourceFactory;
+import org.apache.flink.table.factories.FactoryUtil;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Tests for {@link DataGenTableSourceFactory}.
Review comment:
update the note
##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/filesystem/FileSystemTableFactoryTest.java
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.filesystem;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+import org.apache.flink.table.catalog.ObjectIdentifier;
+import org.apache.flink.table.connector.sink.DynamicTableSink;
+import org.apache.flink.table.connector.source.DynamicTableSource;
+import org.apache.flink.table.descriptors.DescriptorProperties;
+import org.apache.flink.table.factories.DataGenTableSourceFactory;
+import org.apache.flink.table.factories.FactoryUtil;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Tests for {@link DataGenTableSourceFactory}.
+ */
+public class FileSystemTableFactoryTest {
+
+ private static final TableSchema TEST_SCHEMA = TableSchema.builder()
+ .field("f0", DataTypes.STRING())
+ .field("f1", DataTypes.BIGINT())
+ .field("f2", DataTypes.BIGINT())
+ .build();
+
+ @Test
+ public void testSourceSink() throws Exception {
+ DescriptorProperties descriptor = new DescriptorProperties();
+ descriptor.putString(FactoryUtil.CONNECTOR.key(), "filesystem");
+ descriptor.putString("path", "/tmp");
+ descriptor.putString("format", "csv");
+
+ DynamicTableSource source = createSource(descriptor);
+ Assert.assertTrue(source instanceof FileSystemTableSource);
+
+ DynamicTableSink sink = createSink(descriptor);
+ Assert.assertTrue(sink instanceof FileSystemTableSink);
+ }
+
+ @Test
+ public void testLackOptionSource() {
+ DescriptorProperties descriptor = new DescriptorProperties();
+ descriptor.putString(FactoryUtil.CONNECTOR.key(), "filesystem");
+ descriptor.putString("path", "/tmp");
+
+ try {
+ createSource(descriptor);
+ } catch (ValidationException e) {
+ Throwable cause = e.getCause();
+ Assert.assertTrue(cause.toString(), cause instanceof ValidationException);
+ Assert.assertTrue(cause.getMessage(), cause.getMessage().contains(
+ "Missing required options are:\n\nformat"));
+ return;
+ }
+
+ Assert.fail("Should fail by ValidationException.");
+ }
+
+ @Test
+ public void testLackOptionSink() {
+ DescriptorProperties descriptor = new DescriptorProperties();
+ descriptor.putString(FactoryUtil.CONNECTOR.key(), "filesystem");
+ descriptor.putString("path", "/tmp");
+
+ try {
+ createSink(descriptor);
+ } catch (ValidationException e) {
+ Throwable cause = e.getCause();
+ Assert.assertTrue(cause.toString(), cause instanceof ValidationException);
+ Assert.assertTrue(cause.getMessage(), cause.getMessage().contains(
+ "Missing required options are:\n\nformat"));
+ return;
+ }
+
+ Assert.fail("Should fail by ValidationException.");
+ }
+
+ @Test
+ public void testUnsupportedOptionSource() {
+ DescriptorProperties descriptor = new DescriptorProperties();
+ descriptor.putString(FactoryUtil.CONNECTOR.key(), "filesystem");
+ descriptor.putString("path", "/tmp");
+ descriptor.putString("format", "csv");
+ descriptor.putString("my_option", "my");
+
+ try {
+ createSource(descriptor);
+ } catch (ValidationException e) {
+ Throwable cause = e.getCause();
+ Assert.assertTrue(cause.toString(), cause instanceof ValidationException);
+ Assert.assertTrue(cause.getMessage(), cause.getMessage().contains(
+ "Unsupported options:\n\nmy_option"));
+ return;
+ }
+
+ Assert.fail("Should fail by ValidationException.");
+ }
+
+ @Test
+ public void testUnsupportedOptionSink() {
+ DescriptorProperties descriptor = new DescriptorProperties();
+ descriptor.putString(FactoryUtil.CONNECTOR.key(), "filesystem");
+ descriptor.putString("path", "/tmp");
+ descriptor.putString("format", "csv");
+ descriptor.putString("my_option", "my");
+
+ try {
+ createSink(descriptor);
+ } catch (ValidationException e) {
+ Throwable cause = e.getCause();
+ Assert.assertTrue(cause.toString(), cause instanceof ValidationException);
+ Assert.assertTrue(cause.getMessage(), cause.getMessage().contains(
+ "Unsupported options:\n\nmy_option"));
+ return;
+ }
+
+ Assert.fail("Should fail by ValidationException.");
+ }
+
+ private static DynamicTableSource createSource(DescriptorProperties properties) {
+ return FactoryUtil.createTableSource(
+ null,
+ ObjectIdentifier.of("", "", ""),
Review comment:
That's better we can given a more readable identifier like `ObjectIdentifier.of("mycatalog", "mydb", "mytable")`
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -351,19 +315,34 @@ public void setStaticPartition(Map<String, String> partitions) {
}
@Override
- public TableSchema getTableSchema() {
- return schema;
+ public boolean requiresPartitionGrouping(boolean supportsGrouping) {
+ this.dynamicGrouping = supportsGrouping;
+ return dynamicGrouping;
}
@Override
- public DataType getConsumedDataType() {
- return schema.toRowDataType().bridgedTo(RowData.class);
+ public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
+ return ChangelogMode.insertOnly();
}
@Override
- public boolean configurePartitionGrouping(boolean supportsGrouping) {
- this.dynamicGrouping = supportsGrouping;
- return dynamicGrouping;
+ public DynamicTableSink copy() {
+ return new FileSystemTableSink(context, overwrite, dynamicGrouping, staticPartitions);
+ }
+
+ @Override
+ public String asSummaryString() {
+ return "filesystem";
Review comment:
FileSystem
##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroFilesystemStreamITCase.java
##########
@@ -32,7 +32,7 @@
public String[] additionalProperties() {
List<String> ret = new ArrayList<>();
ret.add("'format'='avro'");
- ret.add("'format.avro.codec'='snappy'");
Review comment:
Considering the format options is not validated, I suggest at least add one test in `FileSystemTableFactoryTest`
##########
File path: flink-table/flink-sql-client/pom.xml
##########
@@ -96,6 +96,12 @@ under the License.
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
Review comment:
why we bundle this dependency here? test scope is enough if for test purpose
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java
##########
@@ -226,87 +195,63 @@ public long getPushedDownLimit() {
spec.forEach((k, v) -> ret.put(k, defaultPartName.equals(v) ? null : v));
return ret;
})
- .collect(Collectors.toList());
+ .collect(Collectors.toList()));
} catch (Exception e) {
throw new TableException("Fetch partitions fail.", e);
}
}
@Override
- public FileSystemTableSource applyPartitionPruning(
- List<Map<String, String>> remainingPartitions) {
- return new FileSystemTableSource(
- schema,
- path,
- partitionKeys,
- defaultPartName,
- properties,
- remainingPartitions,
- selectFields,
- limit,
- filters);
+ public void applyPartitions(List<Map<String, String>> remainingPartitions) {
+ this.remainingPartitions = remainingPartitions;
}
@Override
- public FileSystemTableSource projectFields(int[] fields) {
- return new FileSystemTableSource(
- schema,
- path,
- partitionKeys,
- defaultPartName,
- properties,
- readPartitions,
- fields,
- limit,
- filters);
+ public boolean supportsNestedProjection() {
+ return false;
}
@Override
- public FileSystemTableSource applyLimit(long limit) {
- return new FileSystemTableSource(
- schema,
- path,
- partitionKeys,
- defaultPartName,
- properties,
- readPartitions,
- selectFields,
- limit,
- filters);
+ public void applyProjection(int[][] projectedFields) {
+ this.projectedFields = projectedFields;
}
@Override
- public boolean isLimitPushedDown() {
- return limit != null;
+ public FileSystemTableSource copy() {
+ return new FileSystemTableSource(context, projectedFields, remainingPartitions, filters, limit);
}
@Override
- public FileSystemTableSource applyPredicate(List<Expression> predicates) {
- return new FileSystemTableSource(
- schema,
- path,
- partitionKeys,
- defaultPartName,
- properties,
- readPartitions,
- selectFields,
- limit,
- new ArrayList<>(predicates));
+ public String asSummaryString() {
+ return "filesystem";
Review comment:
Filesystem
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableFactory.java
##########
@@ -48,71 +36,59 @@
* table or a catalog table.
* 2.Support insert into (append) and insert overwrite.
* 3.Support static and dynamic partition inserting.
- *
- * <p>Migrate to new source/sink interface after FLIP-95 is ready.
*/
public class FileSystemTableFactory implements
- TableSourceFactory<RowData>,
- TableSinkFactory<RowData> {
+ DynamicTableSourceFactory,
+ DynamicTableSinkFactory {
public static final String IDENTIFIER = "filesystem";
@Override
- public Map<String, String> requiredContext() {
- Map<String, String> context = new HashMap<>();
- context.put(CONNECTOR, IDENTIFIER);
- return context;
+ public String factoryIdentifier() {
+ return IDENTIFIER;
}
@Override
- public List<String> supportedProperties() {
- // contains format properties.
- return Collections.singletonList("*");
+ public DynamicTableSink createDynamicTableSink(Context context) {
+ validate(FactoryUtil.createTableFactoryHelper(this, context));
+ return new FileSystemTableSink(context);
}
@Override
- public TableSource<RowData> createTableSource(TableSourceFactory.Context context) {
- Configuration conf = new Configuration();
- context.getTable().getOptions().forEach(conf::setString);
-
- return new FileSystemTableSource(
- TableSchemaUtils.getPhysicalSchema(context.getTable().getSchema()),
- getPath(conf),
- context.getTable().getPartitionKeys(),
- conf.get(PARTITION_DEFAULT_NAME),
- context.getTable().getProperties());
+ public DynamicTableSource createDynamicTableSource(Context context) {
+ validate(FactoryUtil.createTableFactoryHelper(this, context));
+ return new FileSystemTableSource(context);
}
- @Override
- public TableSink<RowData> createTableSink(TableSinkFactory.Context context) {
- Configuration conf = new Configuration();
- context.getTable().getOptions().forEach(conf::setString);
-
- return new FileSystemTableSink(
- context.getObjectIdentifier(),
- context.isBounded(),
- TableSchemaUtils.getPhysicalSchema(context.getTable().getSchema()),
- getPath(conf),
- context.getTable().getPartitionKeys(),
- conf.get(PARTITION_DEFAULT_NAME),
- context.getTable().getOptions());
+ private void validate(FactoryUtil.TableFactoryHelper helper) {
+ // Except format options, some format like parquet and orc can not list all support options.
Review comment:
```suggestion
// Except format options, some formats like parquet and orc can not list all supported options.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218)
* 0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715244864
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 11330173d2fcaeead16e067e1f7d31c50081c2e1 (Fri Oct 23 10:10:20 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-717011897
Thanks @leonardBang for the review, merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #13767:
URL: https://github.com/apache/flink/pull/13767#discussion_r512024364
##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroFilesystemStreamITCase.java
##########
@@ -32,7 +32,7 @@
public String[] additionalProperties() {
List<String> ret = new ArrayList<>();
ret.add("'format'='avro'");
- ret.add("'format.avro.codec'='snappy'");
Review comment:
Considering the format options is never validated, I suggest at least add one test in `FileSystemTableFactoryTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13767:
URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11330173d2fcaeead16e067e1f7d31c50081c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8176",
"triggerID" : "7e5bf1cc81043553e2f6df80a6b6412634c80609",
"triggerType" : "PUSH"
}, {
"hash" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218",
"triggerID" : "c532d886b68b7dd265c9056945a3cfc94e8352b7",
"triggerType" : "PUSH"
}, {
"hash" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260",
"triggerID" : "0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN
* c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218)
* 0b644cc4e0ffb153ecdd67e8d4ba214341dc1a06 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8260)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org